Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-19 Thread Josh Don
On Mon, Apr 19, 2021 at 2:01 AM Peter Zijlstra wrote: > > Josh, you being on the other Google team, the one that actually uses the > cgroup interface AFAIU, can you fight the good fight with TJ on this? A bit of extra context is in https://lore.kernel.org/lkml/cabk29nttscu2ho7v9di+fh2gv8zu5xic5in

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-19 Thread Tejun Heo
Hello, Sorry about late reply. On Wed, Apr 07, 2021 at 08:34:24PM +0200, Peter Zijlstra wrote: > > Given the existence of prctl and clone APIs, I don't see the reason to > > have a separate cgroup-bound interface too (as argued by Tejun). > > IMO as long as cgroups have that tasks file, you get

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-19 Thread Peter Zijlstra
On Sat, Apr 17, 2021 at 09:35:07PM -0400, Joel Fernandes wrote: > On Tue, Apr 06, 2021 at 10:16:12AM -0400, Tejun Heo wrote: > > Hello, > > > > On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote: > > > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com > > > as me

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-17 Thread Joel Fernandes
On Tue, Apr 06, 2021 at 10:16:12AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote: > > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com > > as mentioned above, let me know if you need any more details about > > usecase. >

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-08 Thread Josh Don
On Thu, Apr 8, 2021 at 9:47 AM Peter Zijlstra wrote: > > On Thu, Apr 08, 2021 at 03:25:52PM +0200, Michal Koutný wrote: > > > I'm curious whether the cgroup API actually simplifies things that are > > possible with the clone/prctl API or allows anything that wouldn't be > > otherwise possible. > >

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-08 Thread Peter Zijlstra
On Thu, Apr 08, 2021 at 03:25:52PM +0200, Michal Koutný wrote: > On Wed, Apr 07, 2021 at 08:34:24PM +0200, Peter Zijlstra > wrote: > > IMO as long as cgroups have that tasks file, you get to support people > > using it. That means that tasks joining your cgroup need to 'inherit' > > cgroup proper

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-08 Thread Michal Koutný
On Wed, Apr 07, 2021 at 08:34:24PM +0200, Peter Zijlstra wrote: > IMO as long as cgroups have that tasks file, you get to support people > using it. That means that tasks joining your cgroup need to 'inherit' > cgroup properties. The tasks file is consequence of binding this to cgroups, I'm one s

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-07 Thread Peter Zijlstra
On Tue, Apr 06, 2021 at 12:08:50PM -0400, Tejun Heo wrote: > I see. Yeah, if we really need it, I'm not sure it fits in cgroup interface > proper. As I wrote elsewhere, these things are usually implemented on the > originating subsystem interface with cgroup ID as a parameter. This would be somet

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-07 Thread Peter Zijlstra
On Wed, Apr 07, 2021 at 06:50:32PM +0200, Michal Koutný wrote: > Hello. > > IIUC, the premise is that the tasks that have different cookies imply > they would never share a core. Correct. > On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > > The cgroup interface now uses a 'core_

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-07 Thread Michal Koutný
Hello. IIUC, the premise is that the tasks that have different cookies imply they would never share a core. On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > The cgroup interface now uses a 'core_sched' file, which still takes 0,1. It > is > however changed such that you can have

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-06 Thread Tejun Heo
Hello, On Tue, Apr 06, 2021 at 05:32:04PM +0200, Peter Zijlstra wrote: > > I find it difficult to like the proposed interface from the name (the term > > "core" is really confusing given how the word tends to be used internally) > > to the semantics (it isn't like anything else) and even the funct

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-06 Thread Peter Zijlstra
On Sun, Apr 04, 2021 at 07:39:03PM -0400, Tejun Heo wrote: > cc'ing Michal and Christian who've been spending some time on cgroup > interface issues recently and Li Zefan for cpuset. > > On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > > The cgroup interface now uses a 'core_sched

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-06 Thread Tejun Heo
Hello, On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote: > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com > as mentioned above, let me know if you need any more details about > usecase. Except for the unspecified reason in usecase 4, I don't see why cgroup

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-05 Thread Joel Fernandes
Hi TJ, Peter, On Sun, Apr 4, 2021 at 7:39 PM Tejun Heo wrote: > > cc'ing Michal and Christian who've been spending some time on cgroup > interface issues recently and Li Zefan for cpuset. > > On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > > The cgroup interface now uses a 'core

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-04 Thread Tejun Heo
cc'ing Michal and Christian who've been spending some time on cgroup interface issues recently and Li Zefan for cpuset. On Thu, Apr 01, 2021 at 03:10:12PM +0200, Peter Zijlstra wrote: > The cgroup interface now uses a 'core_sched' file, which still takes 0,1. It > is > however changed such that y