Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-26 Thread Andy Shevchenko
On Sun, Feb 26, 2017 at 1:30 PM, Michał Kępień wrote: >> On Fri, Feb 17, 2017 at 6:17 AM, Jonathan Woithe wrote: >> > On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote: >> >> On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: >> >> > Do you want me to continue to use Acked

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-26 Thread Michał Kępień
> On Fri, Feb 17, 2017 at 6:17 AM, Jonathan Woithe wrote: > > On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote: > >> On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > >> > Do you want me to continue to use Acked-by, or should I switch to > >> > Reviewed-by? > >> > >> Th

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-24 Thread Darren Hart
On Fri, Feb 17, 2017 at 08:14:51AM +0100, Michał Kępień wrote: > > On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > > > On Thu, Feb 16, 2017 at 06:57:08PM -0800, Darren Hart wrote: > > > > On Fri, Feb 10, 2017 at 02:42:00AM +0200, Andy Shevchenko wrote: > > > > > On Fri, Feb 10, 2

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-24 Thread Andy Shevchenko
On Fri, Feb 17, 2017 at 6:17 AM, Jonathan Woithe wrote: > On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote: >> On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: >> > Do you want me to continue to use Acked-by, or should I switch to >> > Reviewed-by? >> >> These tags do ha

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Michał Kępień
> On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > > On Thu, Feb 16, 2017 at 06:57:08PM -0800, Darren Hart wrote: > > > On Fri, Feb 10, 2017 at 02:42:00AM +0200, Andy Shevchenko wrote: > > > > On Fri, Feb 10, 2017 at 2:16 AM, Jonathan Woithe > > > > wrote: > > > > > On Wed, Feb

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Darren Hart
On Fri, Feb 17, 2017 at 02:47:56PM +1030, Jonathan Woithe wrote: > On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote: > > On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > > > Do you want me to continue to use Acked-by, or should I switch to > > > Reviewed-by? > > > > Th

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Jonathan Woithe
On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote: > On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > > Do you want me to continue to use Acked-by, or should I switch to > > Reviewed-by? > > These tags do have different meanings, and have come up at Kernel Summit the >

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Darren Hart
On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote: > On Thu, Feb 16, 2017 at 06:57:08PM -0800, Darren Hart wrote: > > On Fri, Feb 10, 2017 at 02:42:00AM +0200, Andy Shevchenko wrote: > > > On Fri, Feb 10, 2017 at 2:16 AM, Jonathan Woithe > > > wrote: > > > > On Wed, Feb 08, 2017 at

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Jonathan Woithe
On Thu, Feb 16, 2017 at 06:57:08PM -0800, Darren Hart wrote: > On Fri, Feb 10, 2017 at 02:42:00AM +0200, Andy Shevchenko wrote: > > On Fri, Feb 10, 2017 at 2:16 AM, Jonathan Woithe wrote: > > > On Wed, Feb 08, 2017 at 02:46:23PM +0100, Micha?? K??pie?? wrote: > > > > > In summary, I see no issues

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-16 Thread Darren Hart
On Fri, Feb 10, 2017 at 02:42:00AM +0200, Andy Shevchenko wrote: > On Fri, Feb 10, 2017 at 2:16 AM, Jonathan Woithe wrote: > > On Wed, Feb 08, 2017 at 02:46:23PM +0100, Micha?? K??pie?? wrote: > > > In summary, I see no issues with this patch series which provides a much > > needed clean up of th

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-09 Thread Andy Shevchenko
On Fri, Feb 10, 2017 at 2:16 AM, Jonathan Woithe wrote: > On Wed, Feb 08, 2017 at 02:46:23PM +0100, Micha?? K??pie?? wrote: > In summary, I see no issues with this patch series which provides a much > needed clean up of the code and naming conventions within the fujitsu-laptop > driver. I'm happ

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-09 Thread Jonathan Woithe
On Wed, Feb 08, 2017 at 02:46:23PM +0100, Micha?? K??pie?? wrote: > This series of patches was originally submitted by Alan Jenkins in > September 2009. ... I have applied and tested this patch series on an S7020. Being an older model (and the one the driver was originally targetting) means that

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Michał Kępień
> Hi Michael > > Thanks very much for the work you've put in to clean up these patches. I > very much appreciate it. I will go through them myself in the next day or > so, and most importantly test them on my hardware to confirm there are no > regressions. Thanks! I did my best to keep track o

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Michał Kępień
> Regarding ACPI case and device presents you may assume it if you just call > acpi_walk_namespace() (AFAIU) and check _STA for the device if it's in > the table. > > So, at any point you may have got understanding if device is present > or not, and if it's active or not. Thank you for the tip, t

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Andy Shevchenko
On Thu, Feb 9, 2017 at 3:36 AM, Darren Hart wrote: > On Wed, Feb 08, 2017 at 05:24:53PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 8, 2017 at 3:46 PM, Michał Kępień wrote: >> Nice clean up! >> So, I would apply 1-7, for the rest I need more time to review. > > As a point of policy for this tre

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Darren Hart
On Wed, Feb 08, 2017 at 05:24:53PM +0200, Andy Shevchenko wrote: > On Wed, Feb 8, 2017 at 3:46 PM, Michał Kępień wrote: ... > > Nice clean up! > So, I would apply 1-7, for the rest I need more time to review. As a point of policy for this tree. If the patches touch a file with a driver maintai

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Jonathan Woithe
Hi Michael Thanks very much for the work you've put in to clean up these patches. I very much appreciate it. I will go through them myself in the next day or so, and most importantly test them on my hardware to confirm there are no regressions. Some initial comments follow. On Wed, Feb 08, 201

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

2017-02-08 Thread Andy Shevchenko
On Wed, Feb 8, 2017 at 3:46 PM, Michał Kępień wrote: > This series of patches was originally submitted by Alan Jenkins in > September 2009. For various reasons they were never acted upon before. > Sadly, their original state makes them unreviewable due to multiple > changes happening within one p