Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-26 Thread Maxime Ripard
On Thu, Aug 25, 2016 at 12:54:14AM +0100, André Przywara wrote: > >> Now the long part > >> > >> Basically I see those issues with the new clocks: > >> - sunxi-ng requires a complicated SoC specific source file in the > >> kernel. Although that makes the DT pretty easy (and avoids breaking it

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-24 Thread André Przywara
Hi Maxime, thanks for your answer, much appreciated! On 23/08/16 20:31, Maxime Ripard wrote: > Hi Andre, > > On Mon, Aug 01, 2016 at 02:43:06AM +0100, André Przywara wrote: >> Hi Maxime, >> >> On 26/07/16 21:30, Maxime Ripard wrote: >>> Hi, >>> >>> Here is the previous A64 patches made by Andre

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-23 Thread Maxime Ripard
Hi Andre, On Mon, Aug 01, 2016 at 02:43:06AM +0100, André Przywara wrote: > Hi Maxime, > > On 26/07/16 21:30, Maxime Ripard wrote: > > Hi, > > > > Here is the previous A64 patches made by Andre [1], reworked to use > > the new sunxi-ng clock framework. > > > > This uses the current H3 clock cod

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-10 Thread André Przywara
On 01/08/16 10:11, Chen-Yu Tsai wrote: > Hi, Hi Chen-Yu, thanks for your comments, just found some time to come back to this. > > On Mon, Aug 1, 2016 at 9:43 AM, André Przywara wrote: >> Hi Maxime, >> >> On 26/07/16 21:30, Maxime Ripard wrote: >>> Hi, >>> >>> Here is the previous A64 patches m

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Jean-Francois Moine
On Mon, 1 Aug 2016 20:01:49 +0800 Chen-Yu Tsai wrote: > On Mon, Aug 1, 2016 at 8:00 PM, Jean-Francois Moine wrote: > > On Mon, 1 Aug 2016 17:13:34 +0800 > > Chen-Yu Tsai wrote: > > > >> > But I don't see why you are keeping the simple-gates. The bus gate may > >> > be ungated/gated when the clo

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Chen-Yu Tsai
On Mon, Aug 1, 2016 at 8:00 PM, Jean-Francois Moine wrote: > On Mon, 1 Aug 2016 17:13:34 +0800 > Chen-Yu Tsai wrote: > >> > But I don't see why you are keeping the simple-gates. The bus gate may >> > be ungated/gated when the clock is enabled/disabled, and that's what >> > Allwinner's software do

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Jean-Francois Moine
On Mon, 1 Aug 2016 17:13:34 +0800 Chen-Yu Tsai wrote: > > But I don't see why you are keeping the simple-gates. The bus gate may > > be ungated/gated when the clock is enabled/disabled, and that's what > > Allwinner's software does. > > For peripherals that have a separate mod clock, having them

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Andre Przywara
Hi Jean-Francois, On 01/08/16 09:30, Jean-Francois Moine wrote: > On Mon, 1 Aug 2016 02:43:06 +0100 > André Przywara wrote: > >> As this became quite a long read, here a TL;DR: >> - We consider using an SCPI based clock system for the A64, alongside >> allwinner,simple-gates and fixed clocks. We

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Chen-Yu Tsai
On Mon, Aug 1, 2016 at 4:30 PM, Jean-Francois Moine wrote: > On Mon, 1 Aug 2016 02:43:06 +0100 > André Przywara wrote: > >> As this became quite a long read, here a TL;DR: >> - We consider using an SCPI based clock system for the A64, alongside >> allwinner,simple-gates and fixed clocks. We try t

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Chen-Yu Tsai
Hi, On Mon, Aug 1, 2016 at 9:43 AM, André Przywara wrote: > Hi Maxime, > > On 26/07/16 21:30, Maxime Ripard wrote: >> Hi, >> >> Here is the previous A64 patches made by Andre [1], reworked to use >> the new sunxi-ng clock framework. >> >> This uses the current H3 clock code, as both are really si

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Jean-Francois Moine
On Mon, 1 Aug 2016 02:43:06 +0100 André Przywara wrote: > As this became quite a long read, here a TL;DR: > - We consider using an SCPI based clock system for the A64, alongside > allwinner,simple-gates and fixed clocks. We try to avoid any Allwinner > specific clocks (apart from the simple-gates

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-07-31 Thread André Przywara
Hi Maxime, On 26/07/16 21:30, Maxime Ripard wrote: > Hi, > > Here is the previous A64 patches made by Andre [1], reworked to use > the new sunxi-ng clock framework. > > This uses the current H3 clock code, as both are really similar. The > first patches are just meant to rework slightly the H3 c

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-07-31 Thread Maxime Ripard
On Fri, Jul 29, 2016 at 07:48:00AM +0200, Jean-Francois Moine wrote: > On Thu, 28 Jul 2016 22:07:05 +0200 > Maxime Ripard wrote: > > > > > Let me know what you think, > > > > > > I don't see the interest to have common code for 32bits and 64bits. > > > The clock driver of a SoC will never evolve

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-07-28 Thread Jean-Francois Moine
On Thu, 28 Jul 2016 22:07:05 +0200 Maxime Ripard wrote: > > > Let me know what you think, > > > > I don't see the interest to have common code for 32bits and 64bits. > > The clock driver of a SoC will never evolve, so, it is simpler to > > copy the source common with the H3 into a clean A64 cloc

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-07-28 Thread Maxime Ripard
On Wed, Jul 27, 2016 at 10:46:23AM +0200, Jean-Francois Moine wrote: > On Tue, 26 Jul 2016 22:30:28 +0200 > Maxime Ripard wrote: > > > ere is the previous A64 patches made by Andre [1], reworked to use > > the new sunxi-ng clock framework. > > > > This uses the current H3 clock code, as both are

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-07-27 Thread Jean-Francois Moine
On Tue, 26 Jul 2016 22:30:28 +0200 Maxime Ripard wrote: > ere is the previous A64 patches made by Andre [1], reworked to use > the new sunxi-ng clock framework. > > This uses the current H3 clock code, as both are really similar. The > first patches are just meant to rework slightly the H3 code,