Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-08 Thread Miklos Szeredi
On Mon, Feb 8, 2021 at 3:02 PM Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 09:25:22AM +0100, Miklos Szeredi wrote: > > On Mon, Feb 8, 2021 at 3:00 AM Dave Chinner wrote: > > > > > > On Wed, Feb 03, 2021 at 04:03:06PM +0100, Miklos Szeredi wrote: > > > > On Wed, Feb 3, 2021 at 3:56 PM Matthe

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-08 Thread Matthew Wilcox
On Mon, Feb 08, 2021 at 09:25:22AM +0100, Miklos Szeredi wrote: > On Mon, Feb 8, 2021 at 3:00 AM Dave Chinner wrote: > > > > On Wed, Feb 03, 2021 at 04:03:06PM +0100, Miklos Szeredi wrote: > > > On Wed, Feb 3, 2021 at 3:56 PM Matthew Wilcox wrote: > > > > > > > But let's talk specifics. What doe

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-08 Thread Miklos Szeredi
On Mon, Feb 8, 2021 at 3:00 AM Dave Chinner wrote: > > On Wed, Feb 03, 2021 at 04:03:06PM +0100, Miklos Szeredi wrote: > > On Wed, Feb 3, 2021 at 3:56 PM Matthew Wilcox wrote: > > > > > But let's talk specifics. What does CIFS need to contact the server for? > > > Could it be cached earlier? > >

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-07 Thread Dave Chinner
On Wed, Feb 03, 2021 at 04:03:06PM +0100, Miklos Szeredi wrote: > On Wed, Feb 3, 2021 at 3:56 PM Matthew Wilcox wrote: > > > But let's talk specifics. What does CIFS need to contact the server for? > > Could it be cached earlier? > > I don't understand what CIFS is doing, and I don't really car

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Miklos Szeredi
On Wed, Feb 3, 2021 at 3:56 PM Matthew Wilcox wrote: > But let's talk specifics. What does CIFS need to contact the server for? > Could it be cached earlier? I don't understand what CIFS is doing, and I don't really care. This is the sort of operation where adding a couple of network roundtri

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Matthew Wilcox
On Wed, Feb 03, 2021 at 03:38:54PM +0100, Miklos Szeredi wrote: > On Wed, Feb 3, 2021 at 3:28 PM Matthew Wilcox wrote: > > > > On Wed, Feb 03, 2021 at 03:13:29PM +0100, Miklos Szeredi wrote: > > > On Wed, Feb 3, 2021 at 2:58 PM Matthew Wilcox wrote: > > > > > > > Network filesystems frequently ne

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Miklos Szeredi
On Wed, Feb 3, 2021 at 3:28 PM Matthew Wilcox wrote: > > On Wed, Feb 03, 2021 at 03:13:29PM +0100, Miklos Szeredi wrote: > > On Wed, Feb 3, 2021 at 2:58 PM Matthew Wilcox wrote: > > > > > Network filesystems frequently need to use the credentials attached to > > > a struct file in order to commun

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Matthew Wilcox
On Wed, Feb 03, 2021 at 03:13:29PM +0100, Miklos Szeredi wrote: > On Wed, Feb 3, 2021 at 2:58 PM Matthew Wilcox wrote: > > > Network filesystems frequently need to use the credentials attached to > > a struct file in order to communicate with the server. There's no point > > fighting this realit

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Miklos Szeredi
On Wed, Feb 3, 2021 at 2:58 PM Matthew Wilcox wrote: > Network filesystems frequently need to use the credentials attached to > a struct file in order to communicate with the server. There's no point > fighting this reality. IDGI. Credentials can be taken from the file and from the task. In t

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Matthew Wilcox
On Wed, Feb 03, 2021 at 02:13:27PM +0100, Miklos Szeredi wrote: > On Wed, Feb 3, 2021 at 2:08 PM Matthew Wilcox wrote: > > > > On Wed, Feb 03, 2021 at 01:40:54PM +0100, Miklos Szeredi wrote: > > > This series adds the infrastructure and conversion of filesystems to the > > > new API. > > > > > > T

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Miklos Szeredi
On Wed, Feb 3, 2021 at 2:08 PM Matthew Wilcox wrote: > > On Wed, Feb 03, 2021 at 01:40:54PM +0100, Miklos Szeredi wrote: > > This series adds the infrastructure and conversion of filesystems to the > > new API. > > > > Two filesystems are not converted: FUSE and CIFS, as they behave > > differentl

Re: [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR

2021-02-03 Thread Matthew Wilcox
On Wed, Feb 03, 2021 at 01:40:54PM +0100, Miklos Szeredi wrote: > This series adds the infrastructure and conversion of filesystems to the > new API. > > Two filesystems are not converted: FUSE and CIFS, as they behave > differently from local filesystems (use the file pointer, don't perform > per