Re: [PATCH 00/24] objtool: retpoline and asm-goto validation

2018-01-23 Thread Peter Zijlstra
On Tue, Jan 23, 2018 at 03:57:39PM +, David Woodhouse wrote: > On Tue, 2018-01-23 at 16:42 +0100, Peter Zijlstra wrote: > > drivers/watchdog/.tmp_hpwdt.o: warning: objtool: .text+0x24: indirect call > > found in RETPOLINE build > > You're calling into BIOS there. Not a lot of point in protect

Re: [PATCH 00/24] objtool: retpoline and asm-goto validation

2018-01-23 Thread David Woodhouse
On Tue, 2018-01-23 at 16:42 +0100, Peter Zijlstra wrote: > drivers/watchdog/.tmp_hpwdt.o: warning: objtool: .text+0x24: indirect call > found in RETPOLINE build You're calling into BIOS there. Not a lot of point in protecting that one. This is one of the cases where we were saying you needed to t

Re: [PATCH 00/24] objtool: retpoline and asm-goto validation

2018-01-23 Thread Peter Zijlstra
On Tue, Jan 23, 2018 at 04:25:39PM +0100, Peter Zijlstra wrote: > This series adds two features to objtool: > > - retpoline validation; it verifies no indirect jumps/calls are left in >CONFIG_RETPOLINE=y builds. > >includes fixups for kvm and others > > - asm-goto validation; allows as