Re: [PATCH 00/29] RFC: iov_iter: Switch to using an ops table

2020-12-10 Thread Matthew Wilcox
On Sat, Nov 21, 2020 at 02:13:21PM +, David Howells wrote: > I had a go switching the iov_iter stuff away from using a type bitmask to > using an ops table to get rid of the if-if-if-if chains that are all over > the place. After I pushed it, someone pointed me at Pavel's two patches. > > I

Re: [PATCH 00/29] RFC: iov_iter: Switch to using an ops table

2020-11-21 Thread Linus Torvalds
On Sat, Nov 21, 2020 at 6:13 AM David Howells wrote: > > Can someone recommend a good way to benchmark this properly? The problem > is that the difference this makes relative to the amount of time taken to > actually do I/O is tiny. Maybe try /dev/zero -> /dev/null to try a load where the IO

Re: [PATCH 00/29] RFC: iov_iter: Switch to using an ops table

2020-11-21 Thread Pavel Begunkov
On 21/11/2020 14:13, David Howells wrote: > > Hi Pavel, Willy, Jens, Al, > > I had a go switching the iov_iter stuff away from using a type bitmask to > using an ops table to get rid of the if-if-if-if chains that are all over > the place. After I pushed it, someone pointed me at Pavel's two