Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-31 Thread Masahiro Yamada
Hi, On Fri, Mar 22, 2019 at 10:59 PM Arnd Bergmann wrote: > > On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen wrote: > > > > From: Andi Kleen > > > > This warning is very noisy in a default build with gcc 9. > > Move it into W=2 only. > > > > Cc: a...@arndb.de > > Cc: Masahiro Yamada > > Signed-of

RE: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-25 Thread David Laight
From: Andi Kleen > Sent: 22 March 2019 16:58 > > Lol... we're actively moving away from the C standard on many places. > > Yes and also packed is not part of the C standard. > > > Why does the silly compiler think it is a problem to take the address of > > a member of a packed structure? That sou

Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-22 Thread Andi Kleen
> Lol... we're actively moving away from the C standard on many places. Yes and also packed is not part of the C standard. > Why does the silly compiler think it is a problem to take the address of > a member of a packed structure? That sounds like something that's > perfectly fine and useful. P

Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-22 Thread Arnd Bergmann
On Fri, Mar 22, 2019 at 5:40 PM Peter Zijlstra wrote: > > On Fri, Mar 22, 2019 at 02:58:51PM +0100, Arnd Bergmann wrote: > > On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen wrote: > > > > > > From: Andi Kleen > > > > > > This warning is very noisy in a default build with gcc 9. > > > Move it into W=

Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-22 Thread Peter Zijlstra
On Fri, Mar 22, 2019 at 02:58:51PM +0100, Arnd Bergmann wrote: > On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen wrote: > > > > From: Andi Kleen > > > > This warning is very noisy in a default build with gcc 9. > > Move it into W=2 only. > > > > Cc: a...@arndb.de > > Cc: Masahiro Yamada > > Signed-o

Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-22 Thread Andi Kleen
On Fri, Mar 22, 2019 at 02:58:51PM +0100, Arnd Bergmann wrote: > On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen wrote: > > > > From: Andi Kleen > > > > This warning is very noisy in a default build with gcc 9. > > Move it into W=2 only. > > > > Cc: a...@arndb.de > > Cc: Masahiro Yamada > > Signed-o

Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

2019-03-22 Thread Arnd Bergmann
On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen wrote: > > From: Andi Kleen > > This warning is very noisy in a default build with gcc 9. > Move it into W=2 only. > > Cc: a...@arndb.de > Cc: Masahiro Yamada > Signed-off-by: Andi Kleen I think W=2 is too aggressive. On many architectures, this find