Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-27 Thread Roland McGrath
> clean. Unless there are major problems with it this looks like 2.6.25 > stuff. Would you mind to send updates/fixes against this tree? I'd be glad to. I'd be very happy to see this stuff make 2.6.25. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-27 Thread Ingo Molnar
* Roland McGrath <[EMAIL PROTECTED]> wrote: > > I did do an experimental will-it-apply and got a tremendous number > > of rejects against the x86 git tree, almost all of which went away > > when `patch -l' was used. Seems that someone has gone on a > > whitespace rampage through arch/x86/ia32

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-27 Thread Roland McGrath
> I think I'll duck this lot for now in view of the (relatively small) amount > of followup. The debugctlmsr bits (last few patches) are meant to be taken with a grain of salt. Everything else in this set is pretty well ready for prime time. > I did do an experimental will-it-apply and got a tre

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-27 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 25 Nov 2007 13:55:07 -0800 (PST) Roland McGrath <[EMAIL PROTECTED]> > wrote: > > > This defines the new macro arch_has_single_step() in linux/ptrace.h, > > a default for when asm/ptrace.h does not define it. It declares the > > new user_en

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-27 Thread Andrew Morton
On Sun, 25 Nov 2007 13:55:07 -0800 (PST) Roland McGrath <[EMAIL PROTECTED]> wrote: > This defines the new macro arch_has_single_step() in linux/ptrace.h, a > default for when asm/ptrace.h does not define it. It declares the new > user_enable_single_step and user_disable_single_step functions. >

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-25 Thread Roland McGrath
> Why should arch_has_single_step be a function-like macro? I can't thing > of a case were this wouln't be a compile-time constant. And given that > this is hopefully a transitionary ifdef because eventually all architectures > would use the generic code I'd prefer ifdefs in the code that clearly

Re: [PATCH 01/27] ptrace: arch_has_single_step

2007-11-25 Thread Christoph Hellwig
On Sun, Nov 25, 2007 at 01:55:07PM -0800, Roland McGrath wrote: > This defines the new macro arch_has_single_step() in linux/ptrace.h, a > default for when asm/ptrace.h does not define it. It declares the new > user_enable_single_step and user_disable_single_step functions. > This is not used yet,