Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-07-07 Thread Vineet Gupta
On Wednesday 08 July 2015 11:14 AM, Viresh Kumar wrote: > On 08-07-15, 11:07, Vineet Gupta wrote: >> Is this series (and other one touching arch/arm/*) specific to ARM event >> timers. >> Are you planning to fixup the drivers in arch/* or the respective >> maintainers need >> to follow suit. > Hi

Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-07-07 Thread Viresh Kumar
On 08-07-15, 11:07, Vineet Gupta wrote: > Is this series (and other one touching arch/arm/*) specific to ARM event > timers. > Are you planning to fixup the drivers in arch/* or the respective maintainers > need > to follow suit. Hi Vineet, I am fixing all clockevent drivers available in Linux

Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-07-07 Thread Vineet Gupta
On Thursday 18 June 2015 04:24 PM, Viresh Kumar wrote: > Migrate asm9260 driver to the new 'set-state' interface provided by > clockevents core, the earlier 'set-mode' interface is marked obsolete > now. > > This also enables us to implement callbacks for new states of clockevent > devices, for ex

Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-06-30 Thread Daniel Lezcano
On 06/30/2015 11:00 AM, Viresh Kumar wrote: On 30-06-15, 10:25, Daniel Lezcano wrote: Could you add in the changelog the subtle change with set_mode(RESUME) and this code. As a default the timer was stopped when entering in the set_mode function, now with the new API, this is done explicitly.

Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-06-30 Thread Viresh Kumar
On 30-06-15, 10:25, Daniel Lezcano wrote: > Could you add in the changelog the subtle change with > set_mode(RESUME) and this code. As a default the timer was stopped > when entering in the set_mode function, now with the new API, this > is done explicitly. > Can you replace this line with a call

Re: [PATCH 01/41] clocksource: asm9260: Migrate to new 'set-state' interface

2015-06-30 Thread Daniel Lezcano
On 06/18/2015 12:54 PM, Viresh Kumar wrote: Migrate asm9260 driver to the new 'set-state' interface provided by clockevents core, the earlier 'set-mode' interface is marked obsolete now. This also enables us to implement callbacks for new states of clockevent devices, for example: ONESHOT_STOPPE