Re: [PATCH 01/59] arch/ia64: Add missing "space"

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:09:25PM -0800, Joe Perches wrote: > On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote: > > Is it really neccessary for this fragment to create a line that > > is greater than 80 characters long? Persumably the entire reason > > that the printk line was split in the fi

Re: [PATCH 01/59] arch/ia64: Add missing "space"

2007-11-19 Thread Joe Perches
On Tue, 2007-11-20 at 15:54 +0900, Simon Horman wrote: > Is it really neccessary for this fragment to create a line that > is greater than 80 characters long? Persumably the entire reason > that the printk line was split in the first place was to avoid > a long line. No. Many other lines in that

Re: [PATCH 01/59] arch/ia64: Add missing "space"

2007-11-19 Thread Simon Horman
[snip] > diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c > index 5fd65d8..90518e4 100644 > --- a/arch/ia64/kernel/kprobes.c > +++ b/arch/ia64/kernel/kprobes.c > @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint > slot, > qp = kprobe_inst & 0