Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Bart Van Assche
On 08/02/2016 12:30 PM, Steven Rostedt wrote: [ removed most the Cc list ] On Tue, Aug 02, 2016 at 08:14:10AM -0700, Bart Van Assche wrote: Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter form is more compact and hence makes the code easier to read. FYI, Linus alrea

Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Steven Rostedt
[ removed most the Cc list ] On Tue, Aug 02, 2016 at 08:14:10AM -0700, Bart Van Assche wrote: > > Hello Baole, > > Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter > form is more compact and hence makes the code easier to read. > FYI, Linus already NACKed the entire

Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Bart Van Assche
On 08/02/2016 03:55 AM, Baole Ni wrote: I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can