Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Andi Kleen
On Mon, Aug 06, 2007 at 12:10:53PM -0700, Andrew Morton wrote: > On Mon, 6 Aug 2007 20:59:26 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > precious page flag > > > > I always cringe when I hear that. It's really more than node/sparsemem > > use too many bits. If we get rid of 32bit NUMA tha

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Matt Mackall
On Mon, Aug 06, 2007 at 12:10:53PM -0700, Andrew Morton wrote: > On Mon, 6 Aug 2007 20:59:26 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > precious page flag > > > > I always cringe when I hear that. It's really more than node/sparsemem > > use too many bits. If we get rid of 32bit NUMA tha

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Christoph Lameter
On Mon, 6 Aug 2007, Andrew Morton wrote: > Plus I don't think there are many flags left in the upper 32-bits. ia64 > swooped in and gobbled lots of them, although it's not immediately clear > how many were consumed. IA64 uses one of these bits for the uncached allocator. 10 bits used for the n

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Andrew Morton
On Mon, 6 Aug 2007 20:59:26 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > precious page flag > > I always cringe when I hear that. It's really more than node/sparsemem > use too many bits. If we get rid of 32bit NUMA that problem would be > gone for the node at least because it could be moved i

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Christoph Lameter
On Mon, 6 Aug 2007, Andi Kleen wrote: > I always cringe when I hear that. It's really more than node/sparsemem > use too many bits. If we get rid of 32bit NUMA that problem would be > gone for the node at least because it could be moved into the mostly > unused upper 32bit part on 64bit architectu

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Andi Kleen
> precious page flag I always cringe when I hear that. It's really more than node/sparsemem use too many bits. If we get rid of 32bit NUMA that problem would be gone for the node at least because it could be moved into the mostly unused upper 32bit part on 64bit architectures. The alternative wou

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Peter Zijlstra
On Mon, 2007-08-06 at 11:43 -0700, Christoph Lameter wrote: > On Mon, 6 Aug 2007, Andi Kleen wrote: > > > > > pgoff_t index; /* Our offset within mapping. */ > > > > void *freelist; /* SLUB: freelist req. slab > > > > lock */ > > > > +

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Christoph Lameter
On Mon, 6 Aug 2007, Andi Kleen wrote: > > > pgoff_t index; /* Our offset within mapping. */ > > > void *freelist; /* SLUB: freelist req. slab lock */ > > > + int reserve;/* page_alloc: page is a reserve page */ > > > > Extending page struct

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Andi Kleen
Christoph Lameter <[EMAIL PROTECTED]> writes: > On Mon, 6 Aug 2007, Peter Zijlstra wrote: > > > === > > --- linux-2.6-2.orig/include/linux/mm_types.h > > +++ linux-2.6-2/include/linux/mm_types.h > > @@ -60,6 +60,7 @@ struct page { >

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Peter Zijlstra
On Mon, 2007-08-06 at 11:11 -0700, Christoph Lameter wrote: > On Mon, 6 Aug 2007, Peter Zijlstra wrote: > > > === > > --- linux-2.6-2.orig/include/linux/mm_types.h > > +++ linux-2.6-2/include/linux/mm_types.h > > @@ -60,6 +60,7 @@ str

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Daniel Phillips
On Monday 06 August 2007 11:11, Christoph Lameter wrote: > On Mon, 6 Aug 2007, Peter Zijlstra wrote: > > === > > --- linux-2.6-2.orig/include/linux/mm_types.h > > +++ linux-2.6-2/include/linux/mm_types.h > > @@ -60,6 +60,7 @@ struct pa

Re: [PATCH 03/10] mm: tag reseve pages

2007-08-06 Thread Christoph Lameter
On Mon, 6 Aug 2007, Peter Zijlstra wrote: > === > --- linux-2.6-2.orig/include/linux/mm_types.h > +++ linux-2.6-2/include/linux/mm_types.h > @@ -60,6 +60,7 @@ struct page { > union { > pgoff_t index; /* Ou