Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-12-11 Thread Richard Guy Briggs
On 13/12/11, John Johansen wrote: > On 12/11/2013 06:47 AM, Richard Guy Briggs wrote: > > On Tue, Sep 03, 2013 at 02:31:59PM -0400, Richard Guy Briggs wrote: > >> On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: > >>> On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: > On Tue, Au

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-12-11 Thread John Johansen
On 12/11/2013 06:47 AM, Richard Guy Briggs wrote: > On Tue, Sep 03, 2013 at 02:31:59PM -0400, Richard Guy Briggs wrote: >> On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: >>> On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nestero

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-12-11 Thread Richard Guy Briggs
On Tue, Sep 03, 2013 at 02:31:59PM -0400, Richard Guy Briggs wrote: > On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: > > On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: > > > On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: > > >> On 08/20, Richard Guy Briggs wrote:

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-09-03 Thread Richard Guy Briggs
On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: > On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: > > On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: > >> On 08/20, Richard Guy Briggs wrote: > > Most of the instances are current, but the one called from apparmour is

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-08-30 Thread John Johansen
On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: > On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: >> On 08/20, Richard Guy Briggs wrote: >>> >>> Added the functions >>> task_ppid() >>> task_ppid_nr_ns() >>> task_ppid_nr_init_ns() >>> to safely abstract the l

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-08-30 Thread Richard Guy Briggs
On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: > On 08/20, Richard Guy Briggs wrote: > > > > Added the functions > > task_ppid() > > task_ppid_nr_ns() > > task_ppid_nr_init_ns() > > to safely abstract the lookup of the PPID > > but it is not safe. > > > +st

Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely

2013-08-27 Thread Oleg Nesterov
On 08/20, Richard Guy Briggs wrote: > > Added the functions > task_ppid() > task_ppid_nr_ns() > task_ppid_nr_init_ns() > to safely abstract the lookup of the PPID but it is not safe. > +static inline struct pid *task_ppid(struct task_struct *task) > +{ > + return task_