Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-28 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > --- > block/blk-core.c | 1 - > drivers/mtd/mtdcore.c | 1 + > fs/9p/vfs_super.c | 4 ++-- > fs/afs/super.c| 1 - > fs/btrf

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-22 Thread David Sterba
On Wed, Jul 22, 2020 at 08:25:42AM +0200, Christoph Hellwig wrote: > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > --- For the btrfs bits > fs/btrfs/disk-io.c| 1 - Acked-by: David Sterba

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 11:27:57PM +0200, Richard Weinberger wrote: > On Mon, Jul 20, 2020 at 2:37 PM Artem Bityutskiy wrote: > > > > On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote: > > > What about jffs2 and blk2mtd raw block devices? > > I don't worry much about blk2mtd. > > > If m

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Richard Weinberger
On Mon, Jul 20, 2020 at 2:37 PM Artem Bityutskiy wrote: > > On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote: > > What about jffs2 and blk2mtd raw block devices? I don't worry much about blk2mtd. > If my memory serves me correctly JFFS2 did not mind readahead. This covers my knowledge

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Artem Bityutskiy
On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote: > What about jffs2 and blk2mtd raw block devices? If my memory serves me correctly JFFS2 did not mind readahead.

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Christoph Hellwig
On Mon, Jul 20, 2020 at 01:58:22PM +0200, Richard Weinberger wrote: > Hello Chrstoph, > > On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > > > Set up a readahead size by default. This changes behavior for mtd, > > ubifs, and vboxsf to actually enabled readahead, the lack of which > >

Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

2020-07-20 Thread Richard Weinberger
Hello Chrstoph, On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > Set up a readahead size by default. This changes behavior for mtd, > ubifs, and vboxsf to actually enabled readahead, the lack of which > very much looks like an oversight. UBIFS doesn't enable readahead on purpose, pl