Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Bartosz Golaszewski
2018-03-19 16:38 GMT+01:00 Greg Kroah-Hartman : > On Mon, Mar 19, 2018 at 01:56:28PM +0100, Bartosz Golaszewski wrote: >> 2018-03-19 13:51 GMT+01:00 Peter Rosin : >> > On 2018-03-19 13:12, Bartosz Golaszewski wrote: >> >> 2018-03-19 12:03 GMT+01:00 Peter Rosin : >> >>> Also, use a // style comment

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Greg Kroah-Hartman
On Mon, Mar 19, 2018 at 01:56:28PM +0100, Bartosz Golaszewski wrote: > 2018-03-19 13:51 GMT+01:00 Peter Rosin : > > On 2018-03-19 13:12, Bartosz Golaszewski wrote: > >> 2018-03-19 12:03 GMT+01:00 Peter Rosin : > >>> Also, use a // style comment for the SPDX line in C files. > >> > >> I'm seeing bot

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Bartosz Golaszewski
2018-03-19 13:51 GMT+01:00 Peter Rosin : > On 2018-03-19 13:12, Bartosz Golaszewski wrote: >> 2018-03-19 12:03 GMT+01:00 Peter Rosin : >>> Also, use a // style comment for the SPDX line in C files. >> >> I'm seeing both /* */ and // style comments used for SPDX headers - is >> there any reason not

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Peter Rosin
On 2018-03-19 13:12, Bartosz Golaszewski wrote: > 2018-03-19 12:03 GMT+01:00 Peter Rosin : >> Also, use a // style comment for the SPDX line in C files. > > I'm seeing both /* */ and // style comments used for SPDX headers - is > there any reason not to use /* */ here? Documentation/process/licen

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Bartosz Golaszewski
2018-03-19 12:03 GMT+01:00 Peter Rosin : > On 2018-03-19 10:17, Bartosz Golaszewski wrote: >> Replace the GPL header with an SPDX identifier for GPL-2.0. > > Great care should be exercised when dealing with copyrights of others. > >> >> Signed-off-by: Bartosz Golaszewski >> --- >> drivers/misc/ee

Re: [PATCH 04/21] eeprom: at24: use SPDX identifier instead of GPL boiler-plate

2018-03-19 Thread Peter Rosin
On 2018-03-19 10:17, Bartosz Golaszewski wrote: > Replace the GPL header with an SPDX identifier for GPL-2.0. Great care should be exercised when dealing with copyrights of others. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/misc/eeprom/at24.c | 7 ++- > 1 file changed, 2 insert