Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

2016-01-05 Thread Jiri Olsa
On Mon, Dec 21, 2015 at 11:26:48PM +0900, Namhyung Kim wrote: SNIP > + free(str); > + return ret; > +} > + > static int __sort_dimension__add(struct sort_dimension *sd) > { > if (sd->taken) > @@ -1667,6 +1887,9 @@ static int sort_dimension__add(const char *tok, sort_dimension__ad

Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

2015-12-20 Thread Namhyung Kim
Hi Jiri, On Sun, Dec 20, 2015 at 02:51:32PM +0100, Jiri Olsa wrote: > On Wed, Dec 16, 2015 at 12:35:38AM +0900, Namhyung Kim wrote: > > SNIP > > > + > > + if (!len) > > + len = hde_width(hde); > > + > > + return len; > > +} > > + > > +static int __sort__hde_entry(struct perf_hpp_fm

Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

2015-12-20 Thread Jiri Olsa
On Wed, Dec 16, 2015 at 12:35:38AM +0900, Namhyung Kim wrote: SNIP > + > + if (!len) > + len = hde_width(hde); > + > + return len; > +} > + > +static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, > + struct hist_entry *he) > +{