Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-20 Thread Roger Quadros
On 19/12/18 19:18, Tony Lindgren wrote: > * Mark Brown [181219 17:07]: >> On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote: >>> On 12/19/18 4:43 PM, Roger Quadros wrote: >> Did I do something wrong or we just need to enhance regmap_debugfs.c? >> >>> Do you assign the name field i

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-19 Thread Tony Lindgren
* Mark Brown [181219 17:07]: > On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote: > > On 12/19/18 4:43 PM, Roger Quadros wrote: > > > > Did I do something wrong or we just need to enhance regmap_debugfs.c? > > > Do you assign the name field in pru_regmap_config and > > pru_debug_regm

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-19 Thread Mark Brown
On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote: > On 12/19/18 4:43 PM, Roger Quadros wrote: > > Did I do something wrong or we just need to enhance regmap_debugfs.c? > Do you assign the name field in pru_regmap_config and > pru_debug_regmap_config? Yeah, you'll at least need to ov

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-19 Thread David Lechner
On 12/19/18 4:43 PM, Roger Quadros wrote: On 19/12/18 14:38, Mark Brown wrote: On Tue, Dec 18, 2018 at 05:51:12PM +0200, Roger Quadros wrote: We could combine control and debug into one iomap and use 2 regmap ranges. But this is really working around the regmap_mmio limitation of not being

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-19 Thread Roger Quadros
On 19/12/18 14:38, Mark Brown wrote: > On Tue, Dec 18, 2018 at 05:51:12PM +0200, Roger Quadros wrote: > >> We could combine control and debug into one iomap and use >> 2 regmap ranges. But this is really working around the >> regmap_mmio limitation of not being able to use more than one ioremaps.

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-19 Thread Mark Brown
On Tue, Dec 18, 2018 at 05:51:12PM +0200, Roger Quadros wrote: > We could combine control and debug into one iomap and use > 2 regmap ranges. But this is really working around the > regmap_mmio limitation of not being able to use more than one ioremaps. > Mark, any suggestions? If they're separa

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-12-18 Thread Roger Quadros
+Mark David, On 29/11/18 12:17, Roger Quadros wrote: > On 27/11/18 00:37, David Lechner wrote: >> On 11/26/18 1:52 AM, Roger Quadros wrote: >>> From: Suman Anna >>> >>> The remoteproc core creates certain standard debugfs entries, >>> that does not give a whole lot of useful information for the

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-11-29 Thread Roger Quadros
On 27/11/18 00:37, David Lechner wrote: > On 11/26/18 1:52 AM, Roger Quadros wrote: >> From: Suman Anna >> >> The remoteproc core creates certain standard debugfs entries, >> that does not give a whole lot of useful information for the >> PRUs. The PRU remoteproc driver is enhanced to add addition

Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

2018-11-26 Thread David Lechner
On 11/26/18 1:52 AM, Roger Quadros wrote: From: Suman Anna The remoteproc core creates certain standard debugfs entries, that does not give a whole lot of useful information for the PRUs. The PRU remoteproc driver is enhanced to add additional debugfs entries for PRU. These will be auto-cleaned