Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 02:57:12PM +0100, Lee Jones wrote: > On 30/07/12 14:39, Mark Brown wrote: > >Why does the driver care - doesn't the pinctrl abstraction and/or > >bindings handle this sensibly? > Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0, > MSP2 & MSP3, then when it

Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

2012-07-30 Thread Lee Jones
On 30/07/12 14:39, Mark Brown wrote: On Mon, Jul 30, 2012 at 07:53:36AM +0100, Lee Jones wrote: On 29/07/12 21:42, Mark Brown wrote: + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) This doesn't seem particularly sane... why is this conditional? It's conditional because

Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

2012-07-30 Thread Mark Brown
On Mon, Jul 30, 2012 at 07:53:36AM +0100, Lee Jones wrote: > On 29/07/12 21:42, Mark Brown wrote: > >>+ if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > >This doesn't seem particularly sane... why is this conditional? > It's conditional because only MSP1 and MSP3 have pinctrl suppor

Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

2012-07-29 Thread Lee Jones
On 29/07/12 21:42, Mark Brown wrote: On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) + msp->use_pinctrl = true; + else + msp->use_pinctrl = false; I don't recall seeing any response t

Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

2012-07-29 Thread Mark Brown
On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > + msp->use_pinctrl = true; > + else > + msp->use_pinctrl = false; I don't recall seeing any response to my query about this on the first iterat