Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-12 Thread Ian Abbott
On 2013-04-11 20:05, Greg Kroah-Hartman wrote: On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote: Ian Abbott wrote: Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. It seems to work okay and is simpler than I thoug

Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread Greg Kroah-Hartman
On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote: > Ian Abbott wrote: > > > > Don't use create_proc_read_entry() as that is deprecated, but rather use > > > proc_create_data() and seq_file instead. > > > > It seems to work okay and is simpler than I thought it would be! You > > ch

Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Ian Abbott wrote: > > Don't use create_proc_read_entry() as that is deprecated, but rather use > > proc_create_data() and seq_file instead. > > It seems to work okay and is simpler than I thought it would be! You changed > the mode of the file to 0644 for some reason though. Please change it b

Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread Ian Abbott
On 2013-04-11 14:28, David Howells wrote: Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. It seems to work okay and is simpler than I thought it would be! You changed the mode of the file to 0644 for some reason though. Please