Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t

2017-11-22 Thread Luc Van Oostenryck
On Wed, Nov 22, 2017 at 02:24:02PM -0800, Matthew Wilcox wrote: > On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote: > > > - root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1; > > > + root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1); > > > > IMO, it would be better to define

Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t

2017-11-22 Thread Matthew Wilcox
On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote: > > - root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1; > > + root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1); > > IMO, it would be better to define something for that in radix-tree.h, > like it has been done for ROOT_

Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t

2017-11-22 Thread Luc Van Oostenryck
On Wed, Nov 22, 2017 at 01:06:42PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > sparse complains about an invalid type assignment. > > Signed-off-by: Matthew Wilcox > --- > lib/radix-tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/radix-tree.c b/