Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-23 Thread Mel Gorman
On Fri, Jul 20, 2012 at 10:54:17AM -0500, Jonathan Nieder wrote: > Mel Gorman wrote: > > On Thu, Jul 19, 2012 at 05:07:21PM -0500, Jonathan Nieder wrote: > > >> Some of the other patches of this type made sense, but I'd personally > >> prefer if this one was dropped, yes. Though I am just a nobod

Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-20 Thread Jonathan Nieder
Mel Gorman wrote: > On Thu, Jul 19, 2012 at 05:07:21PM -0500, Jonathan Nieder wrote: >> Some of the other patches of this type made sense, but I'd personally >> prefer if this one was dropped, yes. Though I am just a nobody that >> reads patches rather than one of the relevant people. ;-) > > It'

Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-20 Thread Mel Gorman
On Thu, Jul 19, 2012 at 05:07:21PM -0500, Jonathan Nieder wrote: > Mel Gorman wrote: > > On Thu, Jul 19, 2012 at 03:30:17PM -0500, Jonathan Nieder wrote: > > >> It doesn't sound like it fixes a serious issue. > > > > You're right, it doesn't. There are a few patches in this series that > > were ap

Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-19 Thread Jonathan Nieder
Mel Gorman wrote: > On Thu, Jul 19, 2012 at 03:30:17PM -0500, Jonathan Nieder wrote: >> It doesn't sound like it fixes a serious issue. > > You're right, it doesn't. There are a few patches in this series that > were applied because they made other patches easier to apply and this is > one of them

Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-19 Thread Mel Gorman
On Thu, Jul 19, 2012 at 03:30:17PM -0500, Jonathan Nieder wrote: > Mel Gorman wrote: > > > From: Dave Chinner > > > > commit 095760730c1047c69159ce88021a7fa3833502c8 upstream. > > > > Stable note: Not tracked in Bugzilla. This is a diagnostic patch that > > was part of a series addressing exc

Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints

2012-07-19 Thread Jonathan Nieder
Mel Gorman wrote: > From: Dave Chinner > > commit 095760730c1047c69159ce88021a7fa3833502c8 upstream. > > Stable note: Not tracked in Bugzilla. This is a diagnostic patch that > was part of a series addressing excessive slab shrinking after > GFP_NOFS failures. There is detailed inform