Re: [PATCH 06/35] mfd: ab8500-core: Sysfs chip id modification

2013-02-20 Thread Lee Jones
On Wed, 20 Feb 2013, Marcus Cooper wrote: > On 20 February 2013 09:13, Lee Jones wrote: > > On Tue, 19 Feb 2013, Arnd Bergmann wrote: > > > >> On Friday 15 February 2013, Lee Jones wrote: > >> > struct ab8500 *ab8500; > >> > + int chip_id = -EINVAL; > >> > > >> > ab8500 = de

Re: [PATCH 06/35] mfd: ab8500-core: Sysfs chip id modification

2013-02-20 Thread Marcus Cooper
On 20 February 2013 09:13, Lee Jones wrote: > On Tue, 19 Feb 2013, Arnd Bergmann wrote: > >> On Friday 15 February 2013, Lee Jones wrote: >> > struct ab8500 *ab8500; >> > + int chip_id = -EINVAL; >> > >> > ab8500 = dev_get_drvdata(dev); >> > - return sprintf(buf, "%#x\n

Re: [PATCH 06/35] mfd: ab8500-core: Sysfs chip id modification

2013-02-20 Thread Lee Jones
On Tue, 19 Feb 2013, Arnd Bergmann wrote: > On Friday 15 February 2013, Lee Jones wrote: > > struct ab8500 *ab8500; > > + int chip_id = -EINVAL; > > > > ab8500 = dev_get_drvdata(dev); > > - return sprintf(buf, "%#x\n", ab8500 ? ab8500->chip_id : -EINVAL); > > + if

Re: [PATCH 06/35] mfd: ab8500-core: Sysfs chip id modification

2013-02-19 Thread Arnd Bergmann
On Friday 15 February 2013, Lee Jones wrote: > struct ab8500 *ab8500; > + int chip_id = -EINVAL; > > ab8500 = dev_get_drvdata(dev); > - return sprintf(buf, "%#x\n", ab8500 ? ab8500->chip_id : -EINVAL); > + if(ab8500) { > + chip_id = ab8500->chip_id; >