Re: [PATCH 06/44 take 2] [UBI] startup code

2007-05-17 Thread Artem Bityutskiy
Christoph, On Thu, 2007-05-17 at 15:44 +0100, Christoph Hellwig wrote: > So both I and Rusty told you not to do this and you did it anyway. > > I'm quite pissed about this ignorance. Andrew, what do we do about such > a case? Should we just revert ubi until they fixed their mess up? Just for r

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-05-17 Thread Christoph Hellwig
On Sun, Feb 25, 2007 at 05:58:28AM +, Christoph Hellwig wrote: > > Why not? We tried to avoid this but found out that this is the most > > decent interface. Specific advises are welcome. > > because this type of compount interface is really painful for the user. > the module.param=foo syntax m

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-03-05 Thread Frank Haverkamp
Hi Rusty, On Mon, 2007-02-26 at 09:03 +1100, Rusty Russell wrote: > On Sun, 2007-02-25 at 05:58 +, Christoph Hellwig wrote: > > On Tue, Feb 20, 2007 at 03:00:56PM +0200, Artem Bityutskiy wrote: > > > > > +module_param_call(mtd, ubi_mtd_param_parse, NULL, NULL, 000); > > > > > +MODULE_PARM_DESC

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-26 Thread Artem Bityutskiy
On Sun, 2007-02-25 at 05:58 +, Christoph Hellwig wrote: > because this type of compount interface is really painful for the user. > the module.param=foo syntax makes sure paramaters can be used without > endless documentation for each and every single of them, and makes > sure module writers do

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-25 Thread Rusty Russell
On Sun, 2007-02-25 at 05:58 +, Christoph Hellwig wrote: > On Tue, Feb 20, 2007 at 03:00:56PM +0200, Artem Bityutskiy wrote: > > > > +module_param_call(mtd, ubi_mtd_param_parse, NULL, NULL, 000); > > > > +MODULE_PARM_DESC(mtd, "MTD devices to attach. Parameter format: " > > > > +

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-24 Thread Christoph Hellwig
On Tue, Feb 20, 2007 at 03:00:56PM +0200, Artem Bityutskiy wrote: > > > +module_param_call(mtd, ubi_mtd_param_parse, NULL, NULL, 000); > > > +MODULE_PARM_DESC(mtd, "MTD devices to attach. Parameter format: " > > > + "mtd=[,,]. " > > > + "Multiple \"mtd\" parameters may b

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-23 Thread Artem Bityutskiy
On Tue, 2007-02-20 at 15:00 +0200, Artem Bityutskiy wrote: > > This looks very odd. > > What exactly? I see, will be fixed, thanks. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-20 Thread Artem Bityutskiy
On Mon, 2007-02-19 at 10:59 +, Christoph Hellwig wrote: > On Sat, Feb 17, 2007 at 06:54:54PM +0200, Artem Bityutskiy wrote: > > +/* UBI headers must take 64 bytes. The below is a hacky way to ensure this > > */ > > +static int __ubi_check_ec_hdr_size[(UBI_EC_HDR_SIZE == 64) - 1] > > +__att

Re: [PATCH 06/44 take 2] [UBI] startup code

2007-02-19 Thread Christoph Hellwig
On Sat, Feb 17, 2007 at 06:54:54PM +0200, Artem Bityutskiy wrote: > +/* UBI headers must take 64 bytes. The below is a hacky way to ensure this */ > +static int __ubi_check_ec_hdr_size[(UBI_EC_HDR_SIZE == 64) - 1] > +__attribute__ ((__unused__)); > +static int __ubi_check_ec_hdr_size[(UBI_VID_H