Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-25 Thread Christoph Hellwig
On Tue, Jul 22, 2014 at 12:18:19AM -0400, Martin K. Petersen wrote: > More nitpicking. In the two previous atomic conversion patches you kept > %hu for the atomic_t. Here it's %d. I'll fix it to use %d everywhere, given that's it's not an unsigned short anymore. -- To unsubscribe from this list:

Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-21 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Avoid taking the host-wide host_lock to check the per-host Christoph> queue limit. Instead we do an atomic_inc_return early on to Christoph> grab our slot in the queue, and if nessecary decrement it Christoph> after finishing all checks.

Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-21 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Avoid taking the host-wide host_lock to check the per-host Christoph> queue limit. Instead we do an atomic_inc_return early on to Christoph> grab our slot in the queue, and if nessecary decrement it

Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-09 Thread Hannes Reinecke
On 06/25/2014 06:51 PM, Christoph Hellwig wrote: Avoid taking the host-wide host_lock to check the per-host queue limit. Instead we do an atomic_inc_return early on to grab our slot in the queue, and if nessecary decrement it after finishing all checks. Signed-off-by: Christoph Hellwig --- dr