Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers

2007-10-23 Thread Jens Axboe
On Mon, Oct 22 2007, Benny Halevy wrote: > It looks like it could be nice to define and use a helper for > page_address(sg_page(sg)) (although 11 call sites could use it > after this patch) > > #define sg_pgaddr(sg) page_address(sg_page(sg)) > > Note that mips sg_{un,}map_sg checked for page_addr

Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers

2007-10-22 Thread Benny Halevy
It looks like it could be nice to define and use a helper for page_address(sg_page(sg)) (although 11 call sites could use it after this patch) #define sg_pgaddr(sg) page_address(sg_page(sg)) Note that mips sg_{un,}map_sg checked for page_address(sg->page) != 0 before calling __dma_sync(addr + sg-