Re: [PATCH 08/11] module: Fix nested sleep

2014-09-30 Thread Peter Zijlstra
On Tue, Sep 30, 2014 at 12:18:23AM +0200, Oleg Nesterov wrote: > On 09/24, Peter Zijlstra wrote: > > > > A genuine bug, we cannot use blocking primitives inside a wait loop. > > > > So rewrite the wait_event_interruptible() usage to use the fresh > > wait_woken() stuff. > > OK, but ... > > > +sta

Re: [PATCH 08/11] module: Fix nested sleep

2014-09-29 Thread Oleg Nesterov
On 09/24, Peter Zijlstra wrote: > > A genuine bug, we cannot use blocking primitives inside a wait loop. > > So rewrite the wait_event_interruptible() usage to use the fresh > wait_woken() stuff. OK, but ... > +static int wait_finished_loading(struct module *mod) > +{ > + DEFINE_WAIT_FUNC(wai