Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-15 Thread Jean Delvare
Hi Steve, On Mon, 14 Jan 2008 22:28:51 +, Steve Hardy wrote: > > As far as I know boolean parameters take values 0 and 1, not N and Y. > > Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface > displays boolean parameters as Y/N, and will accept boot parameters as > either

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-15 Thread Jean Delvare
Hi Steve, On Mon, 14 Jan 2008 22:28:51 +, Steve Hardy wrote: As far as I know boolean parameters take values 0 and 1, not N and Y. Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface displays boolean parameters as Y/N, and will accept boot parameters as either Y/N or

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-14 Thread Steve Hardy
> As far as I know boolean parameters take values 0 and 1, not N and Y. Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface displays boolean parameters as Y/N, and will accept boot parameters as either Y/N or 0/1. Below is a snippet from a test proving this point : [EMAIL

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-14 Thread Steve Hardy
As far as I know boolean parameters take values 0 and 1, not N and Y. Not on the systems I am testing on (2.6.24-rc6) - the sysfs interface displays boolean parameters as Y/N, and will accept boot parameters as either Y/N or 0/1. Below is a snippet from a test proving this point : [EMAIL

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-10 Thread Jean Delvare
Hi Steve, On Fri, 4 Jan 2008 07:34:39 +, Steve Hardy wrote: > Jean - you mentioned declaring the devices as platform data & writing > a new-style I2C driver - are there any examples of this approach I can > refer to? I simply copied what is/was currently in-tree for this > driver, which

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-10 Thread Jean Delvare
Hi Steve, On Fri, 4 Jan 2008 07:34:39 +, Steve Hardy wrote: Jean - you mentioned declaring the devices as platform data writing a new-style I2C driver - are there any examples of this approach I can refer to? I simply copied what is/was currently in-tree for this driver, which seems to

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-09 Thread Andrew Morton
On Fri, 4 Jan 2008 07:34:39 + Steve Hardy <[EMAIL PROTECTED]> wrote: > Andrew/Jean, > > Sorry for the delay - christmas & getting mutt working delayed my > revised patch. Here is an updated patch against 2.6.24-rc6, which > hopefully addresses all comments made so far. > > Jean - you

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-09 Thread Andrew Morton
On Fri, 4 Jan 2008 07:34:39 + Steve Hardy [EMAIL PROTECTED] wrote: Andrew/Jean, Sorry for the delay - christmas getting mutt working delayed my revised patch. Here is an updated patch against 2.6.24-rc6, which hopefully addresses all comments made so far. Jean - you mentioned

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-04 Thread Steve Hardy
Andrew/Jean, Sorry for the delay - christmas & getting mutt working delayed my revised patch. Here is an updated patch against 2.6.24-rc6, which hopefully addresses all comments made so far. Jean - you mentioned declaring the devices as platform data & writing a new-style I2C driver - are there

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-04 Thread Steve Hardy
Andrew/Jean, Sorry for the delay - christmas getting mutt working delayed my revised patch. Here is an updated patch against 2.6.24-rc6, which hopefully addresses all comments made so far. Jean - you mentioned declaring the devices as platform data writing a new-style I2C driver - are there

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-19 Thread Jean Delvare
Hi Steve, On Mon, 03 Dec 2007 17:59:59 +, Steve Hardy wrote: > Here is a patch against 2.6.23.9 which adds support for the > Burr-Brown/Texas-Instruments > ADS7828 12-bit 8-channel A-D converter. > > The chip is used for voltage monitoring on the COTS processor card I am > currently working

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-19 Thread Jean Delvare
Hi Steve, Andrew, Thanks for the review Andrew. I have some more comments, I'll reply to the original post. On Tue, 18 Dec 2007 20:56:44 +, Steve Hardy wrote: > >> +static int ads7828_attach_adapter(struct i2c_adapter *adapter) > >> +{ > >> +if (!(adapter->class & I2C_CLASS_HWMON)) > >>

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-19 Thread Jean Delvare
Hi Steve, Andrew, Thanks for the review Andrew. I have some more comments, I'll reply to the original post. On Tue, 18 Dec 2007 20:56:44 +, Steve Hardy wrote: +static int ads7828_attach_adapter(struct i2c_adapter *adapter) +{ +if (!(adapter-class I2C_CLASS_HWMON)) +

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-19 Thread Jean Delvare
Hi Steve, On Mon, 03 Dec 2007 17:59:59 +, Steve Hardy wrote: Here is a patch against 2.6.23.9 which adds support for the Burr-Brown/Texas-Instruments ADS7828 12-bit 8-channel A-D converter. The chip is used for voltage monitoring on the COTS processor card I am currently working with.

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-18 Thread Steve Hardy
Andrew, Thanks your your comments, I'm currently preparing/testing a revised patch based on your suggestions, which I will post later this week. A couple of comments inline. Steve I wouldn't bother with EXPERIMENTAL personally. It seems a farily pointless thing. OK, I copied one of the

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-18 Thread Steve Hardy
Andrew, Thanks your your comments, I'm currently preparing/testing a revised patch based on your suggestions, which I will post later this week. A couple of comments inline. Steve I wouldn't bother with EXPERIMENTAL personally. It seems a farily pointless thing. OK, I copied one of the

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-12 Thread Andrew Morton
On Mon, 03 Dec 2007 17:59:59 + Steve Hardy <[EMAIL PROTECTED]> wrote: > Hi, > > Here is a patch against 2.6.23.9 which adds support for the > Burr-Brown/Texas-Instruments > ADS7828 12-bit 8-channel A-D converter. > > The chip is used for voltage monitoring on the COTS processor card I am >

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2007-12-12 Thread Andrew Morton
On Mon, 03 Dec 2007 17:59:59 + Steve Hardy [EMAIL PROTECTED] wrote: Hi, Here is a patch against 2.6.23.9 which adds support for the Burr-Brown/Texas-Instruments ADS7828 12-bit 8-channel A-D converter. The chip is used for voltage monitoring on the COTS processor card I am currently