Re: [PATCH 1/1] Perf: fix overwritten of free running PEBSv3 timestamp

2016-02-11 Thread Peter Zijlstra
On Thu, Feb 11, 2016 at 11:39:18AM -0500, Tong Zhang wrote: > How about moving `time' to the `group', Will this help? Somewhat, but the patch is still really horrid. It makes t==0 a special case and seems to scatter this all over the place. It also consumes the last word in that cacheline :/ The

Re: [PATCH 1/1] Perf: fix overwritten of free running PEBSv3 timestamp

2016-02-11 Thread Tong Zhang
How about moving `time' to the `group', Will this help? Regards, Tong Signed-off-by: Tong Zhang -- diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 3f590de..3163598 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -797,6 +797,7 @@ struct

Re: [PATCH 1/1] Perf: fix overwritten of free running PEBSv3 timestamp

2016-02-11 Thread Peter Zijlstra
On Wed, Feb 10, 2016 at 05:38:02PM -0500, Tong Zhang wrote: > commit a7b58d211ba18c9175b139e18b68c86a6bcc3c3f introduced feature of > timestamp on free running PEBSv3, however, the timestamp is later > overwritten, which makes the effort in vain. > > This patch fixed this problem by detecting w