Re: [PATCH 1/1] media: uvc_driver: fix USB Camera ref leak denial of service

2018-05-26 Thread Laurent Pinchart
Hi David, On Saturday, 26 May 2018 19:37:18 EEST David Fries wrote: > Laurent and Mauro, > > I've reviewed Philipp Zabel's 49770 patch, it looks like they > equivalent, but take a different path. My version does the unref in > uvc_unregister_video, Zabel's does the unref in each caller of > uvc_

Re: [PATCH 1/1] media: uvc_driver: fix USB Camera ref leak denial of service

2018-05-26 Thread David Fries
Laurent and Mauro, I've reviewed Philipp Zabel's 49770 patch, it looks like they equivalent, but take a different path. My version does the unref in uvc_unregister_video, Zabel's does the unref in each caller of uvc_unregister_video. I think I would prefer it to be in fewer places. Any ideas on

Re: [PATCH 1/1] media: uvc_driver: fix USB Camera ref leak denial of service

2018-05-26 Thread Laurent Pinchart
Hi David, Thank you for the patch. On Saturday, 26 May 2018 18:50:46 EEST David Fries wrote: > Commit 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic > variable to a reference count") > didn't take into account that while the old counter was initialized to > 0 (no stream open), kref_