Re: [PATCH 1/1] x86_64: fix KASan shadow region page tables

2015-05-28 Thread Alexander Popov
On 26.05.2015 11:52, Andrey Ryabinin wrote: > On 05/25/2015 04:43 PM, Alexander Popov wrote: >> What do you think about leaving the initialization of KASan shadow region >> page tables in arch/x86/kernel/head_64.S and calling something like >> kasan_fixup_early_shadow() before calling kasan_map_ear

Re: [PATCH 1/1] x86_64: fix KASan shadow region page tables

2015-05-26 Thread Andrey Ryabinin
On 05/25/2015 04:43 PM, Alexander Popov wrote: > On 25.05.2015 11:12, Andrey Ryabinin wrote: >> On 05/22/2015 07:03 PM, Alexander Popov wrote: >>> Physical addresses in KASan shadow region page tables need fixup: >>> kernel halts without it if phys_base is not zero. >>> >> >> Indeed. >> Since we ha

Re: [PATCH 1/1] x86_64: fix KASan shadow region page tables

2015-05-25 Thread Alexander Popov
On 25.05.2015 11:12, Andrey Ryabinin wrote: > On 05/22/2015 07:03 PM, Alexander Popov wrote: >> Physical addresses in KASan shadow region page tables need fixup: >> kernel halts without it if phys_base is not zero. >> > > Indeed. > Since we have to patch page tables anyway, compile-time created ka

Re: [PATCH 1/1] x86_64: fix KASan shadow region page tables

2015-05-25 Thread Andrey Ryabinin
On 05/22/2015 07:03 PM, Alexander Popov wrote: > Physical addresses in KASan shadow region page tables need fixup: > kernel halts without it if phys_base is not zero. > Indeed. Since we have to patch page tables anyway, compile-time created kasan page tables become pointless. So, I'd suggest to c