Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-02-07 Thread Hugh Dickins
On Tue, 5 Feb 2013, Mel Gorman wrote: > On Fri, Jan 25, 2013 at 05:54:53PM -0800, Hugh Dickins wrote: > > From: Petr Holasek > > > > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes > > which control merging pages across different numa nodes. > > When it is set to zero only

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-02-05 Thread Mel Gorman
On Fri, Jan 25, 2013 at 05:54:53PM -0800, Hugh Dickins wrote: > From: Petr Holasek > > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes > which control merging pages across different numa nodes. > When it is set to zero only pages from the same node are merged, > otherwise

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-28 Thread Hugh Dickins
On Mon, 28 Jan 2013, Andrew Morton wrote: > On Fri, 25 Jan 2013 17:54:53 -0800 (PST) > Hugh Dickins wrote: > > > +/* Zeroed when merging across nodes is not allowed */ > > +static unsigned int ksm_merge_across_nodes = 1; > > I spose this should be __read_mostly. If __read_mostly is not really a

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-28 Thread Hugh Dickins
On Mon, 28 Jan 2013, Andrew Morton wrote: > On Fri, 25 Jan 2013 17:54:53 -0800 (PST) > Hugh Dickins wrote: > > > --- mmotm.orig/Documentation/vm/ksm.txt 2013-01-25 14:36:31.724205455 > > -0800 > > +++ mmotm/Documentation/vm/ksm.txt 2013-01-25 14:36:38.608205618 -0800 > > @@ -58,6 +58,13 @@

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-28 Thread Andrew Morton
On Fri, 25 Jan 2013 17:54:53 -0800 (PST) Hugh Dickins wrote: > +/* Zeroed when merging across nodes is not allowed */ > +static unsigned int ksm_merge_across_nodes = 1; I spose this should be __read_mostly. If __read_mostly is not really a synonym for __make_write_often_storage_slower. I conti

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-28 Thread Andrew Morton
On Fri, 25 Jan 2013 17:54:53 -0800 (PST) Hugh Dickins wrote: > --- mmotm.orig/Documentation/vm/ksm.txt 2013-01-25 14:36:31.724205455 > -0800 > +++ mmotm/Documentation/vm/ksm.txt2013-01-25 14:36:38.608205618 -0800 > @@ -58,6 +58,13 @@ sleep_millisecs - how many milliseconds >

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-27 Thread Hugh Dickins
On Sat, 26 Jan 2013, Simon Jeons wrote: > On Sat, 2013-01-26 at 18:54 -0800, Hugh Dickins wrote: > > > > So you'd like us to add code for moving a node from one tree to another > > in ksm_migrate_page() (and what would it do when it collides with an > > Without numa awareness, I still can't under

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-26 Thread Simon Jeons
On Sat, 2013-01-26 at 18:54 -0800, Hugh Dickins wrote: > On Sat, 26 Jan 2013, Simon Jeons wrote: > > On Fri, 2013-01-25 at 17:54 -0800, Hugh Dickins wrote: > > > From: Petr Holasek > > > @@ -1122,6 +1166,18 @@ struct rmap_item *unstable_tree_search_i > > > return NULL; > > >

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-26 Thread Hugh Dickins
On Sat, 26 Jan 2013, Simon Jeons wrote: > On Fri, 2013-01-25 at 17:54 -0800, Hugh Dickins wrote: > > From: Petr Holasek > > @@ -1122,6 +1166,18 @@ struct rmap_item *unstable_tree_search_i > > return NULL; > > } > > > > + /* > > +* If tree_pag

Re: [PATCH 1/11] ksm: allow trees per NUMA node

2013-01-26 Thread Simon Jeons
Hi Hugh, On Fri, 2013-01-25 at 17:54 -0800, Hugh Dickins wrote: > From: Petr Holasek > > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_across_nodes > which control merging pages across different numa nodes. > When it is set to zero only pages from the same node are merged, > otherwis