Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Thu, Nov 15, 2012 at 08:56:17AM +0200, Terje Bergström wrote: > On 14.11.2012 22:04, Thierry Reding wrote: > > According to tegra20_clocks_data.c, the maximum clock frequency for > > host1x is 166 MHz, so 216 is probably not a good idea. 150 MHz sounds > > sensible, though. > > > > I was going

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Terje Bergström
On 14.11.2012 22:04, Thierry Reding wrote: > According to tegra20_clocks_data.c, the maximum clock frequency for > host1x is 166 MHz, so 216 is probably not a good idea. 150 MHz sounds > sensible, though. > > I was going to send a new version of the patch set tonight, but I'll > wait until I can t

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 01:15:54PM -0700, Stephen Warren wrote: > On 11/14/2012 01:04 PM, Thierry Reding wrote: > ... > > According to tegra20_clocks_data.c, the maximum clock frequency > > for host1x is 166 MHz, so 216 is probably not a good idea. 150 MHz > > sounds sensible, though. > > As a gen

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Stephen Warren
On 11/14/2012 01:04 PM, Thierry Reding wrote: ... > According to tegra20_clocks_data.c, the maximum clock frequency > for host1x is 166 MHz, so 216 is probably not a good idea. 150 MHz > sounds sensible, though. As a general rule, I wouldn't rely on the upstream clock driver to specify accurate ma

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 09:19:17AM -0700, Stephen Warren wrote: > On 11/14/2012 03:54 AM, Thierry Reding wrote: > > On Wed, Nov 14, 2012 at 12:23:42PM +0200, Terje Bergström wrote: > >> On 14.11.2012 10:49, Thierry Reding wrote: > >>> Can you find out how the host1x clock is setup without this > >>

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Stephen Warren
On 11/14/2012 09:45 AM, Terje Bergström wrote: > On 14.11.2012 18:19, Stephen Warren wrote: >> I'd rather initialize it explicitly. If setting it to 216MHz works >> fine as Terje indicated, we may as well just do that. > > I'd prefer explicit setting, too. > >> I suspect the issue with the origin

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Terje Bergström
On 14.11.2012 18:19, Stephen Warren wrote: > I'd rather initialize it explicitly. If setting it to 216MHz works > fine as Terje indicated, we may as well just do that. I'd prefer explicit setting, too. > I suspect the issue with the original code: > >> { "host1x", "pll_c",14400,

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Stephen Warren
On 11/14/2012 03:54 AM, Thierry Reding wrote: > On Wed, Nov 14, 2012 at 12:23:42PM +0200, Terje Bergström wrote: >> On 14.11.2012 10:49, Thierry Reding wrote: >>> Can you find out how the host1x clock is setup without this >>> change? I was told that freezes can occur when you try to >>> access the

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 05:29:33PM +0200, Terje Bergström wrote: > On 14.11.2012 17:01, Thierry Reding wrote: > > Funny. I just tested with this line removed and I also get the freeze. > > With the line I don't get the freeze. Does the freeze only occur with > > additional patches on top? If so I t

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Terje Bergström
On 14.11.2012 17:01, Thierry Reding wrote: > Funny. I just tested with this line removed and I also get the freeze. > With the line I don't get the freeze. Does the freeze only occur with > additional patches on top? If so I think we should keep the line in for > now because it is what most people

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 10:35:31AM +0200, Terje Bergström wrote: > On 09.11.2012 15:20, Thierry Reding wrote: > > This commit adds the host1x node along with its children to the Tegra20 > > DTSI. Furthermore the OF auxiliary data table is updated to have proper > > names assigned to the platform de

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 12:23:42PM +0200, Terje Bergström wrote: > On 14.11.2012 10:49, Thierry Reding wrote: > > Can you find out how the host1x clock is setup without this change? I > > was told that freezes can occur when you try to access the registers > > without the host1x clock being enabled

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Terje Bergström
On 14.11.2012 10:49, Thierry Reding wrote: > Can you find out how the host1x clock is setup without this change? I > was told that freezes can occur when you try to access the registers > without the host1x clock being enabled. However, the host1x driver > should take care to properly setup the clo

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Thierry Reding
On Wed, Nov 14, 2012 at 10:35:31AM +0200, Terje Bergström wrote: > On 09.11.2012 15:20, Thierry Reding wrote: > > This commit adds the host1x node along with its children to the Tegra20 > > DTSI. Furthermore the OF auxiliary data table is updated to have proper > > names assigned to the platform de

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-14 Thread Terje Bergström
On 09.11.2012 15:20, Thierry Reding wrote: > This commit adds the host1x node along with its children to the Tegra20 > DTSI. Furthermore the OF auxiliary data table is updated to have proper > names assigned to the platform devices instantiated from the device > tree. Moreover, the clocks required

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-13 Thread Mark Zhang
On 11/13/2012 04:04 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Nov 13, 2012 at 04:00:47PM +0800, Mark Zhang wrote: >> On 11/13/2012 03:52 PM, Thierry Reding wrote: Old Signed by an unknown key >>> >>> On Tue, Nov 13, 2012 at 03:45:00PM +0800, Mark Zhang wrote:

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-13 Thread Thierry Reding
On Tue, Nov 13, 2012 at 04:00:47PM +0800, Mark Zhang wrote: > On 11/13/2012 03:52 PM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Tue, Nov 13, 2012 at 03:45:00PM +0800, Mark Zhang wrote: > >> On 11/09/2012 09:20 PM, Thierry Reding wrote: > >>> @@ -116,6 +122,9 @@ static __i

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-13 Thread Mark Zhang
On 11/13/2012 03:52 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Nov 13, 2012 at 03:45:00PM +0800, Mark Zhang wrote: >> On 11/09/2012 09:20 PM, Thierry Reding wrote: >>> @@ -116,6 +122,9 @@ static __initdata struct tegra_clk_init_table >>> tegra_dt_clk_init_table[] = { >

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Thierry Reding
On Tue, Nov 13, 2012 at 03:45:00PM +0800, Mark Zhang wrote: > On 11/09/2012 09:20 PM, Thierry Reding wrote: > > @@ -116,6 +122,9 @@ static __initdata struct tegra_clk_init_table > > tegra_dt_clk_init_table[] = { > > { "sbc2", "pll_p",1, false }, > > { "sb

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Mark Zhang
On 11/09/2012 09:20 PM, Thierry Reding wrote: > This commit adds the host1x node along with its children to the Tegra20 > DTSI. Furthermore the OF auxiliary data table is updated to have proper > names assigned to the platform devices instantiated from the device > tree. Moreover, the clocks requir

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Mark Zhang
On 11/13/2012 02:41 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Nov 13, 2012 at 12:38:34PM +0800, Mark Zhang wrote: >> On 11/12/2012 05:39 PM, Mark Zhang wrote: >>> On 11/09/2012 09:20 PM, Thierry Reding wrote: > [...] @@ -1036,9 +1041,6 @@ static struct clk_duplica

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Thierry Reding
On Tue, Nov 13, 2012 at 12:38:34PM +0800, Mark Zhang wrote: > On 11/12/2012 05:39 PM, Mark Zhang wrote: > > On 11/09/2012 09:20 PM, Thierry Reding wrote: [...] > >> @@ -1036,9 +1041,6 @@ static struct clk_duplicate tegra_clk_duplicates[] = > >> { > >> CLK_DUPLICATE("usbd", "utmip-pad",

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Mark Zhang
On 11/12/2012 05:39 PM, Mark Zhang wrote: > On 11/09/2012 09:20 PM, Thierry Reding wrote: >> This commit adds the host1x node along with its children to the Tegra20 >> DTSI. Furthermore the OF auxiliary data table is updated to have proper >> names assigned to the platform devices instantiated from

Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

2012-11-12 Thread Mark Zhang
On 11/09/2012 09:20 PM, Thierry Reding wrote: > This commit adds the host1x node along with its children to the Tegra20 > DTSI. Furthermore the OF auxiliary data table is updated to have proper > names assigned to the platform devices instantiated from the device > tree. Moreover, the clocks requir