Re: [PATCH 1/2] Bluetooth: hidp: implement hidinput_input_event callback

2013-07-11 Thread Jiri Kosina
On Thu, 11 Jul 2013, Benjamin Tissoires wrote: > We can re-enable hidinput_input_event to allow the leds of bluetooth > keyboards to be set. > Now the callbacks uses hid core to retrieve the right HID report to > send, so this version is safer. > > Signed-off-by: Benjamin Tissoires Acked-by: Ji

Re: [PATCH 1/2] Bluetooth: hidp: implement hidinput_input_event callback

2013-07-11 Thread David Herrmann
Hi On Thu, Jul 11, 2013 at 4:10 PM, Benjamin Tissoires wrote: > Hi David, > > On Thu, Jul 11, 2013 at 4:02 PM, David Herrmann wrote: >> Hi >> >>> +static int hidp_hidinput_event(struct input_dev *dev, unsigned int type, >>> + unsigned int code, int value) >>> +{ >>>

Re: [PATCH 1/2] Bluetooth: hidp: implement hidinput_input_event callback

2013-07-11 Thread Benjamin Tissoires
Hi David, On Thu, Jul 11, 2013 at 4:02 PM, David Herrmann wrote: > Hi > >> +static int hidp_hidinput_event(struct input_dev *dev, unsigned int type, >> + unsigned int code, int value) >> +{ >> + struct hid_device *hid = input_get_drvdata(dev); > > I dislike that

Re: [PATCH 1/2] Bluetooth: hidp: implement hidinput_input_event callback

2013-07-11 Thread David Herrmann
Hi On Thu, Jul 11, 2013 at 3:41 PM, Benjamin Tissoires wrote: > We can re-enable hidinput_input_event to allow the leds of bluetooth > keyboards to be set. > Now the callbacks uses hid core to retrieve the right HID report to > send, so this version is safer. > > Signed-off-by: Benjamin Tissoires