Re: [PATCH 1/2] MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE definition

2014-09-23 Thread Markos Chandras
On 09/22/2014 07:25 PM, Steven Rostedt wrote: > On Mon, 22 Sep 2014 09:55:09 -0700 > David Daney wrote: > >> On 09/22/2014 06:32 AM, Markos Chandras wrote: >>> The MCOUNT_INSN_SIZE is meant to be used to denote the overall >>> size of the mcount() call. Since a jal instruction is used to >>> call

Re: [PATCH 1/2] MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE definition

2014-09-22 Thread Steven Rostedt
On Mon, 22 Sep 2014 09:55:09 -0700 David Daney wrote: > On 09/22/2014 06:32 AM, Markos Chandras wrote: > > The MCOUNT_INSN_SIZE is meant to be used to denote the overall > > size of the mcount() call. Since a jal instruction is used to > > call mcount() the delay slot should be taken into conside

Re: [PATCH 1/2] MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE definition

2014-09-22 Thread David Daney
On 09/22/2014 06:32 AM, Markos Chandras wrote: The MCOUNT_INSN_SIZE is meant to be used to denote the overall size of the mcount() call. Since a jal instruction is used to call mcount() the delay slot should be taken into consideration as well. This also replaces the MCOUNT_INSN_SIZE usage with t