Re: [PATCH 1/2] SDT markers listing by perf

2013-09-25 Thread Masami Hiramatsu
(2013/09/25 15:03), Hemant wrote: >>> I have one doubt here. Why do we need [ARG ...] in the syntax you >>> specified? I believe these args are to fetched from the sdt notes' >>> section of the elf of the executable/library. Or am I taking this in a >>> wrong way and this suggested syntax is actual

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-24 Thread Hemant
On 09/25/2013 10:07 AM, Masami Hiramatsu wrote: > (2013/09/15 20:28), Hemant wrote: >> Hi Masami, > Hi, and sorry for replying so late. I missed this in my mailbox. > >> On 09/04/2013 01:31 PM, Masami Hiramatsu wrote: >>> (2013/09/04 15:42), Namhyung Kim wrote: [SNIP] You need to add it t

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-24 Thread Masami Hiramatsu
(2013/09/15 20:28), Hemant wrote: > Hi Masami, Hi, and sorry for replying so late. I missed this in my mailbox. > On 09/04/2013 01:31 PM, Masami Hiramatsu wrote: >> (2013/09/04 15:42), Namhyung Kim wrote: >>> On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: >>> >>> [SNIP] >>> diff --g

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-15 Thread Hemant
Hi Masami, On 09/04/2013 01:31 PM, Masami Hiramatsu wrote: > (2013/09/04 15:42), Namhyung Kim wrote: >> On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: >> >> [SNIP] >> >>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c >>> index e8a66f9..3d8dcdf 100644 >>> --- a/tools

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-06 Thread Hemant
Hi Namhyung, On 09/06/2013 12:07 PM, Namhyung Kim wrote: Hi Hemant, On Wed, 04 Sep 2013 23:07:57 +0530, Hemant wrote: On 09/04/2013 12:12 PM, Namhyung Kim wrote: On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: + /* +* Look for Section type = SHT_NOTE, flags = no SHF_ALL

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-05 Thread Namhyung Kim
Hi Hemant, On Wed, 04 Sep 2013 23:07:57 +0530, Hemant wrote: > On 09/04/2013 12:12 PM, Namhyung Kim wrote: >> On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: >>> + /* >>> +* Look for Section type = SHT_NOTE, flags = no SHF_ALLOC >>> +* and name = .note.stapsdt >>> +*/ >>> +

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Hemant
On 09/04/2013 12:51 PM, Masami Hiramatsu wrote: (2013/09/03 16:36), Hemant Kumar wrote: diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 5f720dc..f2d17b7 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -197,6 +197,17 @@ struct symsrc { #endif };

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Hemant
On 09/04/2013 01:31 PM, Masami Hiramatsu wrote: > (2013/09/04 15:42), Namhyung Kim wrote: >> On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: >> >> [SNIP] >> >>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c >>> index e8a66f9..3d8dcdf 100644 >>> --- a/tools/perf/builti

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Hemant
On 09/04/2013 12:13 PM, Namhyung Kim wrote: On Tue, 03 Sep 2013 13:49:35 +0530, Hemant wrote: On 09/03/2013 01:06 PM, Hemant Kumar wrote: This patch will enable perf to list all the sdt markers present in an elf file. The markers are present in the .note.stapsdt section of the elf. We can trave

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Hemant
On 09/04/2013 12:12 PM, Namhyung Kim wrote: On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: [SNIP] diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index e8a66f9..3d8dcdf 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c @@ -55,6 +55,7 @@ stat

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Masami Hiramatsu
(2013/09/04 15:42), Namhyung Kim wrote: > On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: > > [SNIP] > >> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c >> index e8a66f9..3d8dcdf 100644 >> --- a/tools/perf/builtin-probe.c >> +++ b/tools/perf/builtin-probe.c >> @@ -55

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-04 Thread Masami Hiramatsu
(2013/09/03 16:36), Hemant Kumar wrote: > diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h > index 5f720dc..f2d17b7 100644 > --- a/tools/perf/util/symbol.h > +++ b/tools/perf/util/symbol.h > @@ -197,6 +197,17 @@ struct symsrc { > #endif > }; > > +/* Note structure */ > +struct s

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-03 Thread Namhyung Kim
On Tue, 03 Sep 2013 13:49:35 +0530, Hemant wrote: > On 09/03/2013 01:06 PM, Hemant Kumar wrote: >> This patch will enable perf to list all the sdt markers present >> in an elf file. The markers are present in the .note.stapsdt section >> of the elf. We can traverse through this section and collect

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-03 Thread Namhyung Kim
On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote: [SNIP] > diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c > index e8a66f9..3d8dcdf 100644 > --- a/tools/perf/builtin-probe.c > +++ b/tools/perf/builtin-probe.c > @@ -55,6 +55,7 @@ static struct { > bool show_funcs;

Re: [PATCH 1/2] SDT markers listing by perf

2013-09-03 Thread Hemant
On 09/03/2013 01:06 PM, Hemant Kumar wrote: This patch will enable perf to list all the sdt markers present in an elf file. The markers are present in the .note.stapsdt section of the elf. We can traverse through this section and collect the required info about the markers. This hasn't been thoro