Re: [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices

2013-07-22 Thread Krzysztof Halasa
Ben Hutchings writes: > I think the problem is that the platform device and the platform data > have not been properly separated. The machine-specific setup functions > should be passing the eth_plat_info and MAC ID into a common ixp4xx > function which would then create the platform device with

Re: [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices

2013-07-21 Thread Ben Hutchings
On Sun, 2013-07-21 at 16:45 +0200, Krzysztof Halasa wrote: > Jonas Gorski writes: > > > ARM requires the cohorent_dma_mask set, so set it for the platform > > devices so that the ethernet driver has access to it. > > I recognize the need to fix this issue and I appreciate your efforts, > but...

Re: [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices

2013-07-21 Thread Krzysztof Halasa
Jonas Gorski writes: > ARM requires the cohorent_dma_mask set, so set it for the platform > devices so that the ethernet driver has access to it. I recognize the need to fix this issue and I appreciate your efforts, but... I think this patch tries to make the driver functional again at all costs