Re: [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes()

2015-08-14 Thread Matt Fleming
On Fri, 14 Aug, at 11:55:27AM, Zhang, Jonathan Zhixiong wrote: > > >Also, this doesn't look like a small function - why is it inlined? > The function grew a bit after its first version. Since it is on the > fence of not being a small function, I did not change it to out of > the line. I will move

Re: [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes()

2015-08-14 Thread Zhang, Jonathan Zhixiong
On 8/13/2015 1:22 AM, Ingo Molnar wrote: * Matt Fleming wrote: From: "Jonathan (Zhixiong) Zhang" Table 8 of UEFI 2.5 section 2.3.6.1 defines mappings from EFI memory types to MAIR attribute encodings for arm64. If the physical address has memory attributes defined by EFI memmap as EFI_ME

Re: [PATCH 1/2] arm64: apei: implement arch_apei_get_mem_attributes()

2015-08-13 Thread Ingo Molnar
* Matt Fleming wrote: > From: "Jonathan (Zhixiong) Zhang" > > Table 8 of UEFI 2.5 section 2.3.6.1 defines mappings from EFI > memory types to MAIR attribute encodings for arm64. > > If the physical address has memory attributes defined by EFI > memmap as EFI_MEMORY_[UC|WC|WT], return appropra