Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-12-01 Thread wangyijing
>>> I want to make sure that the set_capacity call that happens on cache >>> attachment is not necessary when a backing device is attached without >> >> Hi Eric, set_capacity() which removed in this patch is happened at >> cached_dev_init() >> which is called when register a backing device, what

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-12-01 Thread Eric Wheeler
On Thu, 1 Dec 2016, wangyijing wrote: > > >>> It probably is a duplicate set_capacity, but has anyone tested bringing > >>> on > >>> a writeback volume, and late-attaching the cache volume with this patch > >>> applied? > >>> > >>> Otherwise stated, is it possible to get the backing device att

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-12-01 Thread wangyijing
>>> It probably is a duplicate set_capacity, but has anyone tested bringing on >>> a writeback volume, and late-attaching the cache volume with this patch >>> applied? >>> >>> Otherwise stated, is it possible to get the backing device attached >>> without setting the capacity? >> >> Hi Eric, I

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-11-30 Thread Eric Wheeler
On Wed, 30 Nov 2016, wangyijing wrote: > > > 在 2016/11/30 4:49, Eric Wheeler 写道: > > On Fri, 25 Nov 2016, Yijing Wang wrote: > > > >> set_capacity() has been called in bcache_device_init(), > >> remove the redundant one. > >> > >> Signed-off-by: Yijing Wang > >> --- > >> drivers/md/bcache/sup

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-11-29 Thread wangyijing
在 2016/11/30 4:49, Eric Wheeler 写道: > On Fri, 25 Nov 2016, Yijing Wang wrote: > >> set_capacity() has been called in bcache_device_init(), >> remove the redundant one. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/md/bcache/super.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --g

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-11-29 Thread Eric Wheeler
On Fri, 25 Nov 2016, Yijing Wang wrote: > set_capacity() has been called in bcache_device_init(), > remove the redundant one. > > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/super.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcach

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-11-27 Thread wangyijing
在 2016/11/27 15:57, Coly Li 写道: > On 2016/11/25 上午9:39, Yijing Wang wrote: >> set_capacity() has been called in bcache_device_init(), >> remove the redundant one. >> >> Signed-off-by: Yijing Wang >> --- >> drivers/md/bcache/super.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/d

Re: [PATCH 1/2] bcache: Remove redundant set_capacity

2016-11-26 Thread Coly Li
On 2016/11/25 上午9:39, Yijing Wang wrote: > set_capacity() has been called in bcache_device_init(), > remove the redundant one. > > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/super.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcach