Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 07:25:53PM +0200, Nikolaus Voss wrote: > On Wed, 3 Jul 2019, Greg Kroah-Hartman wrote: > > On Fri, Jun 28, 2019 at 12:10:41PM +0200, Nikolaus Voss wrote: > > > On Fri, 28 Jun 2019, Heikki Krogerus wrote: > > > > On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote:

Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-07-03 Thread Nikolaus Voss
On Wed, 3 Jul 2019, Greg Kroah-Hartman wrote: On Fri, Jun 28, 2019 at 12:10:41PM +0200, Nikolaus Voss wrote: On Fri, 28 Jun 2019, Heikki Krogerus wrote: On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: Portinfo bit field is 3 bits wide, not 2 bits. This led to a wrong driver conf

Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-07-03 Thread Greg Kroah-Hartman
On Fri, Jun 28, 2019 at 12:10:41PM +0200, Nikolaus Voss wrote: > On Fri, 28 Jun 2019, Heikki Krogerus wrote: > > On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: > > > Portinfo bit field is 3 bits wide, not 2 bits. This led to > > > a wrong driver configuration for some tps6598x confi

Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-06-28 Thread Nikolaus Voss
On Fri, 28 Jun 2019, Heikki Krogerus wrote: On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: Portinfo bit field is 3 bits wide, not 2 bits. This led to a wrong driver configuration for some tps6598x configurations. Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power

Re: [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width

2019-06-28 Thread Heikki Krogerus
On Fri, Jun 28, 2019 at 11:01:08AM +0200, Nikolaus Voss wrote: > Portinfo bit field is 3 bits wide, not 2 bits. This led to > a wrong driver configuration for some tps6598x configurations. > > Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery > controllers") > Signed-off