Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump

2020-06-22 Thread Linus Torvalds
On Mon, Jun 22, 2020 at 9:24 AM Eric W. Biederman wrote: > > Why do you think the test sig->group_exit_task != NULL should be removed > for the commit to make sense? Because that's what your commit message _said_. It still implies that with your changed language. And honestly, wouldn't it be a

Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump

2020-06-22 Thread Eric W. Biederman
Linus Torvalds writes: > On Fri, Jun 19, 2020 at 11:36 AM Eric W. Biederman > wrote: >> >> Instead test SIGNAL_GROUP_COREDUMP in signal_group_exit(). > > You say "instead", but the patch itself doesn't agree: > >> static inline int signal_group_exit(const struct signal_struct *sig) >> { >> -

Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump

2020-06-22 Thread Oleg Nesterov
On 06/19, Eric W. Biederman wrote: > > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -369,7 +369,6 @@ static int zap_threads(struct task_struct *tsk, struct > mm_struct *mm, > spin_lock_irq(&tsk->sighand->siglock); > if (!signal_group_exit(tsk->signal)) { > mm->core_stat

Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump

2020-06-20 Thread Linus Torvalds
On Fri, Jun 19, 2020 at 11:36 AM Eric W. Biederman wrote: > > Instead test SIGNAL_GROUP_COREDUMP in signal_group_exit(). You say "instead", but the patch itself doesn't agree: > static inline int signal_group_exit(const struct signal_struct *sig) > { > - return (sig->flags & SIGNAL_GROU