On Tue, 15 Jan 2008 14:46:57 -0600 Matt Mackall wrote:
>
> On Tue, 2008-01-15 at 11:10 -0800, Randy Dunlap wrote:
> > On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
> >
> > > 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> > > > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton
On Tue, 2008-01-15 at 11:10 -0800, Randy Dunlap wrote:
> On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
>
> > 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> > > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
>
> > > > @@ -33,71 +34,65 @@ asmlinkage long
2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:
> > Notice that error is already -EINVAL, so a simple goto should suffice.
>
> Yes, for the start of the function you can basically leave it as-is.
>
OK, I will do as you suggest.
On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:
> Notice that error is already -EINVAL, so a simple goto should suffice.
Yes, for the start of the function you can basically leave it as-is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
On Tue, 2008-01-15 at 22:26 +0300, Anton Salikhmetov wrote:
> 2008/1/15, Randy Dunlap <[EMAIL PROTECTED]>:
> > On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
> >
> > > 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> > > > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton
2008/1/15, Randy Dunlap <[EMAIL PROTECTED]>:
> On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
>
> > 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> > > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
>
> > > > @@ -33,71 +34,65 @@ asmlinkage long
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
> 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
> > > @@ -33,71 +34,65 @@ asmlinkage long sys_msync(unsigned long start, size_t
> > > len, int flags)
> > >
2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>:
> On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
> > +++ b/mm/msync.c
> > @@ -1,24 +1,25 @@
> > /*
> > * linux/mm/msync.c
> > *
> > + * The msync() system call.
> > * Copyright (C) 1994-1999 Linus Torvalds
> > + *
> >
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
> +++ b/mm/msync.c
> @@ -1,24 +1,25 @@
> /*
> * linux/mm/msync.c
> *
> + * The msync() system call.
> * Copyright (C) 1994-1999 Linus Torvalds
> + *
> + * Massive code cleanup.
> + * Copyright (C) 2008 Anton Salikhmetov
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
+++ b/mm/msync.c
@@ -1,24 +1,25 @@
/*
* linux/mm/msync.c
*
+ * The msync() system call.
* Copyright (C) 1994-1999 Linus Torvalds
+ *
+ * Massive code cleanup.
+ * Copyright (C) 2008 Anton Salikhmetov [EMAIL
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
+++ b/mm/msync.c
@@ -1,24 +1,25 @@
/*
* linux/mm/msync.c
*
+ * The msync() system call.
* Copyright (C) 1994-1999 Linus Torvalds
+ *
+ * Massive code
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
@@ -33,71 +34,65 @@ asmlinkage long sys_msync(unsigned long start, size_t
len, int flags)
unsigned
2008/1/15, Randy Dunlap [EMAIL PROTECTED]:
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
@@ -33,71 +34,65 @@ asmlinkage long sys_msync(unsigned long start,
On Tue, 2008-01-15 at 22:26 +0300, Anton Salikhmetov wrote:
2008/1/15, Randy Dunlap [EMAIL PROTECTED]:
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:
Notice that error is already -EINVAL, so a simple goto should suffice.
Yes, for the start of the function you can basically leave it as-is.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 08:28:48PM +0100, Peter Zijlstra wrote:
Notice that error is already -EINVAL, so a simple goto should suffice.
Yes, for the start of the function you can basically leave it as-is.
OK, I will do as you suggest. Thank you
On Tue, 2008-01-15 at 11:10 -0800, Randy Dunlap wrote:
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote:
@@ -33,71 +34,65 @@ asmlinkage long
On Tue, 15 Jan 2008 14:46:57 -0600 Matt Mackall wrote:
On Tue, 2008-01-15 at 11:10 -0800, Randy Dunlap wrote:
On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote:
2008/1/15, Christoph Hellwig [EMAIL PROTECTED]:
On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>:
> > Substantial code cleanup of the sys_msync() function:
> >
> > 1) using the PAGE_ALIGN() macro instead of "manual" alignment;
> > 2) improved readability of the loop traversing the process memory regions.
>
> Thanks for doing this. See comments
> Substantial code cleanup of the sys_msync() function:
>
> 1) using the PAGE_ALIGN() macro instead of "manual" alignment;
> 2) improved readability of the loop traversing the process memory regions.
Thanks for doing this. See comments below.
> Signed-off-by: Anton Salikhmetov <[EMAIL
Substantial code cleanup of the sys_msync() function:
1) using the PAGE_ALIGN() macro instead of manual alignment;
2) improved readability of the loop traversing the process memory regions.
Thanks for doing this. See comments below.
Signed-off-by: Anton Salikhmetov [EMAIL PROTECTED]
---
2008/1/14, Miklos Szeredi [EMAIL PROTECTED]:
Substantial code cleanup of the sys_msync() function:
1) using the PAGE_ALIGN() macro instead of manual alignment;
2) improved readability of the loop traversing the process memory regions.
Thanks for doing this. See comments below.
On Sun, 13 Jan 2008 07:39:58 +0300
Anton Salikhmetov <[EMAIL PROTECTED]> wrote:
> Substantial code cleanup of the sys_msync() function:
>
> 1) using the PAGE_ALIGN() macro instead of "manual" alignment;
> 2) improved readability of the loop traversing the process memory regions.
>
>
On Sun, 13 Jan 2008 07:39:58 +0300
Anton Salikhmetov [EMAIL PROTECTED] wrote:
Substantial code cleanup of the sys_msync() function:
1) using the PAGE_ALIGN() macro instead of manual alignment;
2) improved readability of the loop traversing the process memory regions.
Signed-off-by: Anton
24 matches
Mail list logo