Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-10 Thread Lee Jones
On Thu, 06 Jun 2019, Robert Hancock wrote: > On 2019-06-05 11:27 p.m., Lee Jones wrote: > Without having the .of_full_name support, both MFD cells ended up > wrongly matching against the i2c@c device tree node since we just > picked the first one where of_compatible matched. >

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-06 Thread Robert Hancock
On 2019-06-05 11:27 p.m., Lee Jones wrote: Without having the .of_full_name support, both MFD cells ended up wrongly matching against the i2c@c device tree node since we just picked the first one where of_compatible matched. >>> >>> What is contained in each of their resources?

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-05 Thread Lee Jones
On Wed, 05 Jun 2019, Robert Hancock wrote: > On 2019-06-05 12:45 p.m., Lee Jones wrote: > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h > index 99c0395..470f6cb 100644 > --- a/include/linux/mfd/core.h > +++ b/include/linux/mfd/core.h > @@ -55,6 +55,9 @@

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-05 Thread Robert Hancock
On 2019-06-05 12:45 p.m., Lee Jones wrote: diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h index 99c0395..470f6cb 100644 --- a/include/linux/mfd/core.h +++ b/include/linux/mfd/core.h @@ -55,6 +55,9 @@ struct mfd_cell { */ const char

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-05 Thread Lee Jones
On Wed, 05 Jun 2019, Robert Hancock wrote: > On 2019-06-05 12:31 a.m., Lee Jones wrote: > > On Tue, 04 Jun 2019, Robert Hancock wrote: > > > >> Previously the MFD core supported assigning OF nodes to created MFD > >> devices, but relied solely on matching the of_compatible string. This > >>

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-05 Thread Robert Hancock
On 2019-06-05 12:31 a.m., Lee Jones wrote: > On Tue, 04 Jun 2019, Robert Hancock wrote: > >> Previously the MFD core supported assigning OF nodes to created MFD >> devices, but relied solely on matching the of_compatible string. This >> would result in devices being potentially assigned the wrong

Re: [PATCH 1/2] mfd: core: Support multiple OF child devices of the same type

2019-06-05 Thread Lee Jones
On Tue, 04 Jun 2019, Robert Hancock wrote: > Previously the MFD core supported assigning OF nodes to created MFD > devices, but relied solely on matching the of_compatible string. This > would result in devices being potentially assigned the wrong node if > there are multiple devices with the