Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-16 Thread Johannes Thumshirn
On Tue, Jan 16, 2018 at 12:27:33PM +0100, Hannes Reinecke wrote: > In general I'd rather have the tracepoints when actually submitting the > request; with this tracepoint we might be getting a trace which doesn't > really indicate if the command was submitted at all. yes but if we really want to b

Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-16 Thread Christoph Hellwig
On Tue, Jan 16, 2018 at 11:34:00AM +0100, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/host/core.c| 69 > + > include/trace/events/nvme.h | 64 + Pleas keep the trace hea

Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup_cmd

2018-01-16 Thread Hannes Reinecke
On 01/16/2018 11:34 AM, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > --- > drivers/nvme/host/core.c| 69 > + > include/trace/events/nvme.h | 64 + > 2 files changed, 133 insertions(+) > cr