Il 10/01/21 20:35, Linus Walleij ha scritto:
On Sun, Jan 10, 2021 at 3:32 PM AngeloGioacchino Del Regno
wrote:
So, I've retried some basic usage of the regcache, relevant snippets here:
static bool aw9523_volatile_reg(struct device *dev, unsigned int reg)
{
return reg == AW9523_REG_I
On Sun, Jan 10, 2021 at 03:32:47PM +0100, AngeloGioacchino Del Regno wrote:
> Then, the set_bit/clear_bit in aw9523_irq_mask(), aw9523_irq_unmask were
> replaced with calls to regmap_update_bits_async, example:
Why are you trying to use the _async() versions here? Don't you need
the I/O to compl
On Sun, Jan 10, 2021 at 3:32 PM AngeloGioacchino Del Regno
wrote:
> So, I've retried some basic usage of the regcache, relevant snippets here:
> static bool aw9523_volatile_reg(struct device *dev, unsigned int reg)
> {
>
> return reg == AW9523_REG_IN_STATE(0) ||
>reg == AW
Il 10/01/21 15:32, AngeloGioacchino Del Regno ha scritto:
Il 10/01/21 01:24, Linus Walleij ha scritto:
On Sun, Jan 10, 2021 at 12:11 AM AngeloGioacchino Del Regno
wrote:
Il 09/01/21 23:11, Linus Walleij ha scritto:
The major review comment is that it'd be nice if you look into
using regmaps
Il 10/01/21 01:24, Linus Walleij ha scritto:
On Sun, Jan 10, 2021 at 12:11 AM AngeloGioacchino Del Regno
wrote:
Il 09/01/21 23:11, Linus Walleij ha scritto:
The major review comment is that it'd be nice if you look into
using regmaps register cache instead of rolling your own,
and also possi
On Sun, Jan 10, 2021 at 12:11 AM AngeloGioacchino Del Regno
wrote:
> Il 09/01/21 23:11, Linus Walleij ha scritto:
> > The major review comment is that it'd be nice if you look into
> > using regmaps register cache instead of rolling your own,
> > and also possibly using regmaps locking rather tha
Il 09/01/21 23:12, Linus Walleij ha scritto:
On Sat, Jan 9, 2021 at 6:24 PM kernel test robot wrote:
> 880 gpioirq->parent_domain = NULL;
The autobuilder is complaining because your irq chip is not
hierarchical and this is only used for hierarchical irqchips.
I think you can just
Il 09/01/21 23:11, Linus Walleij ha scritto:
On Sat, Jan 9, 2021 at 3:02 PM AngeloGioacchino Del Regno
wrote:
The Awinic AW9523(B) is a multi-function I2C gpio expander in a
TQFN-24L package, featuring PWM (max 37mA per pin, or total max
power 3.2Watts) for LED driving capability.
It has two
On Sat, Jan 9, 2021 at 6:24 PM kernel test robot wrote:
> > 880 gpioirq->parent_domain = NULL;
The autobuilder is complaining because your irq chip is not
hierarchical and this is only used for hierarchical irqchips.
I think you can just delete this line.
Yours,
Linus Walleij
On Sat, Jan 9, 2021 at 3:02 PM AngeloGioacchino Del Regno
wrote:
> The Awinic AW9523(B) is a multi-function I2C gpio expander in a
> TQFN-24L package, featuring PWM (max 37mA per pin, or total max
> power 3.2Watts) for LED driving capability.
>
> It has two ports with 8 pins per port (for a total
Hi AngeloGioacchino,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as docu
11 matches
Mail list logo
