When you resend, please put in the changelog what the affect of this fix
is for the user. Even if it's something like "It doesn't affect the
user normally." that is useful information.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
Sounds great.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, May 19, 2014 at 2:16 AM, Dan Carpenter wrote:
> This patch is great, thanks, don't resend. But I wish the subject said
> "fix" instead of "rewrite". I was expecting it to just be a cleanup.
>
> It helps a lot if `git log --oneline` says which patches should be
> backported.
>
> regards,
This patch is great, thanks, don't resend. But I wish the subject said
"fix" instead of "rewrite". I was expecting it to just be a cleanup.
It helps a lot if `git log --oneline` says which patches should be
backported.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "uns
On Sat, May 17, 2014 at 9:51 PM, David Matlack wrote:
> On Sat, May 17, 2014 at 9:12 PM, Joe Perches wrote:
>> The if seems unnecessary.
>>
>> Perhaps declare a u16 return var or use
>>
>> return lower_16 + upper_16;
>
> I agree it's fishy... but using overflow doesn't produce the same re
On Sat, May 17, 2014 at 9:12 PM, Joe Perches wrote:
> On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
> []
>> diff --git a/drivers/staging/slicoss/slicoss.c
>> b/drivers/staging/slicoss/slicoss.c
> []
>> +static inline u16 __reduce(u32 checksum)
>> +{
>> + u16 lower_16 = checksum & 0x
On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
[]
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
[]
> +static inline u16 __reduce(u32 checksum)
> +{
> + u16 lower_16 = checksum & 0x;
> + u16 upper_16 = (checksum >> 16) & 0x;
> +
> +
7 matches
Mail list logo
