Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-08 Thread Vladislav Valtchev
On Thu, 2018-02-08 at 20:05 +0800, Zamir SUN wrote: > > Hi Vladislav, > > Thanks for the URL. I tried to build from your make8 branch, it works > fine. I must made some copy-paste mistake yesterday. > > Sorry for the noise. > > Thanks. No problem, Zamir. I'm happy that it works. The series ha

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-08 Thread Zamir SUN
On 02/08/2018 01:25 AM, Vladislav Valtchev wrote: > On Wed, 2018-02-07 at 22:01 +0800, Zamir SUN wrote: >> >> While just a note for this, in Fedora 27: >> >> $ if command -v swig; then echo 1; else echo 0; fi >> /usr/bin/swig >> 1 >> >> Actually this test has the same problem as of `which swig` -

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-07 Thread Vladislav Valtchev
On Wed, 2018-02-07 at 22:01 +0800, Zamir SUN wrote: > > While just a note for this, in Fedora 27: > > $ if command -v swig; then echo 1; else echo 0; fi > /usr/bin/swig > 1 > > Actually this test has the same problem as of `which swig` - When swig > exists, the var SWIG_DEFINED will not be 1 (as

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-07 Thread Zamir SUN
On 02/07/2018 10:40 PM, Steven Rostedt wrote: > On Wed, 7 Feb 2018 22:01:46 +0800 > Zamir SUN wrote: > > >> Thanks for the heads-up! I did not see that before. >> >> While just a note for this, in Fedora 27: >> >> $ if command -v swig; then echo 1; else echo 0; fi >> /usr/bin/swig >> 1 >> >> A

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-07 Thread Steven Rostedt
On Wed, 7 Feb 2018 22:01:46 +0800 Zamir SUN wrote: > Thanks for the heads-up! I did not see that before. > > While just a note for this, in Fedora 27: > > $ if command -v swig; then echo 1; else echo 0; fi > /usr/bin/swig > 1 > > Actually this test has the same problem as of `which swig` - Wh

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-07 Thread Zamir SUN
On 02/07/2018 07:18 AM, Steven Rostedt wrote: > On Sun, 4 Feb 2018 11:20:13 +0800 > szts...@gmail.com wrote: > >> From: Zamir SUN >> >> The current detection for swig will cause output to be >> /usr/bin/swig >> y >> So this will never be equal to y. With this patch, the swig path is >> removed

Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

2018-02-06 Thread Steven Rostedt
On Sun, 4 Feb 2018 11:20:13 +0800 szts...@gmail.com wrote: > From: Zamir SUN > > The current detection for swig will cause output to be > /usr/bin/swig > y > So this will never be equal to y. With this patch, the swig path is > removed from output, so the detection can work as expected. > > Fi