Re: [PATCH 1/2] workqueue: remove unneeded test before wake up next worker

2014-07-18 Thread Tejun Heo
On Fri, Jul 18, 2014 at 06:05:14PM -0400, Tejun Heo wrote: > On Wed, Jul 16, 2014 at 06:09:58PM +0800, Lai Jiangshan wrote: > > In this code: > > if ((worker->flags & WORKER_UNBOUND) && need_more_worker(pool)) > > wake_up_worker(pool); > > > > the first test is unneeded. Even the f

Re: [PATCH 1/2] workqueue: remove unneeded test before wake up next worker

2014-07-18 Thread Tejun Heo
On Wed, Jul 16, 2014 at 06:09:58PM +0800, Lai Jiangshan wrote: > In this code: > if ((worker->flags & WORKER_UNBOUND) && need_more_worker(pool)) > wake_up_worker(pool); > > the first test is unneeded. Even the first test is removed, it doesn't affect > the wake-up logic when WO