Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-31 Thread Kamezawa Hiroyuki
On 2015/03/30 18:58, Gu Zheng wrote: > Hi Kame-san, > > On 03/27/2015 12:31 AM, Kamezawa Hiroyuki wrote: > >> On 2015/03/26 13:55, Gu Zheng wrote: >>> Hi Kame-san, >>> On 03/26/2015 11:19 AM, Kamezawa Hiroyuki wrote: >>> On 2015/03/26 11:17, Gu Zheng wrote: > Previously, we build the api

Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-30 Thread Gu Zheng
Hi Kame-san, On 03/27/2015 12:31 AM, Kamezawa Hiroyuki wrote: > On 2015/03/26 13:55, Gu Zheng wrote: >> Hi Kame-san, >> On 03/26/2015 11:19 AM, Kamezawa Hiroyuki wrote: >> >>> On 2015/03/26 11:17, Gu Zheng wrote: Previously, we build the apicid <--> cpuid mapping when the cpu is presen

Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-26 Thread Kamezawa Hiroyuki
On 2015/03/26 13:55, Gu Zheng wrote: > Hi Kame-san, > On 03/26/2015 11:19 AM, Kamezawa Hiroyuki wrote: > >> On 2015/03/26 11:17, Gu Zheng wrote: >>> Previously, we build the apicid <--> cpuid mapping when the cpu is present, >>> but >>> the relationship will be changed if the cpu/node hotplug hap

Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-26 Thread Tejun Heo
On Thu, Mar 26, 2015 at 12:55:04PM +0800, Gu Zheng wrote: > >> +static int apicid_to_x86_cpu[MAX_LOCAL_APIC] = { > >> + [0 ... MAX_LOCAL_APIC - 1] = -1, > >> +}; > > > > > > This patch cannot handle x2apic, which is 32bit. > > IMO, if the apicid is too big (larger than MAX_LOCAL_APIC), we will

Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-25 Thread Gu Zheng
Hi Kame-san, On 03/26/2015 11:19 AM, Kamezawa Hiroyuki wrote: > On 2015/03/26 11:17, Gu Zheng wrote: >> Previously, we build the apicid <--> cpuid mapping when the cpu is present, >> but >> the relationship will be changed if the cpu/node hotplug happenned, because >> we >> always choose the fir

Re: [PATCH 1/2] x86/cpu hotplug: make apicid <--> cpuid mapping persistent

2015-03-25 Thread Kamezawa Hiroyuki
On 2015/03/26 11:17, Gu Zheng wrote: > Previously, we build the apicid <--> cpuid mapping when the cpu is present, > but > the relationship will be changed if the cpu/node hotplug happenned, because we > always choose the first free cpuid for the hot added cpu (whether it is > new-add > or re-add