Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Hi, On 03/08/17 at 04:45pm, Baoquan He wrote: > Forgot cc to Boris, add him. > > On 03/08/17 at 04:18pm, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > > > EFI allocate runtime services regions down from EFI_VA_START, -4G. > > > It should be top-down handling. > > > > > >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Hi, On 03/08/17 at 04:45pm, Baoquan He wrote: > Forgot cc to Boris, add him. > > On 03/08/17 at 04:18pm, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > > > EFI allocate runtime services regions down from EFI_VA_START, -4G. > > > It should be top-down handling. > > > > > >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 11:50am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > > All right, I will just update the code comment. Just back ported kaslr > > to our OS product, people reviewed and found the upper boundary of kaslr > > mm region is EFI_VA_START, that's

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 11:50am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > > All right, I will just update the code comment. Just back ported kaslr > > to our OS product, people reviewed and found the upper boundary of kaslr > > mm region is EFI_VA_START, that's

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 8, 2017 at 3:05 PM, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: >> Yes, it looks better. I can repost with this change. Thanks. > > No it doesn't: > > #define EFI_VA_START ( -4 * (_AC(1, UL) << 30)) > #define EFI_VA_END

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 8, 2017 at 3:05 PM, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: >> Yes, it looks better. I can repost with this change. Thanks. > > No it doesn't: > > #define EFI_VA_START ( -4 * (_AC(1, UL) << 30)) > #define EFI_VA_END (-68 * (_AC(1,

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > All right, I will just update the code comment. Just back ported kaslr > to our OS product, people reviewed and found the upper boundary of kaslr > mm region is EFI_VA_START, that's not correct, it has to be corrected > firstly in

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 06:17:50PM +0800, Baoquan He wrote: > All right, I will just update the code comment. Just back ported kaslr > to our OS product, people reviewed and found the upper boundary of kaslr > mm region is EFI_VA_START, that's not correct, it has to be corrected > firstly in

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 04:45:13PM +0800, Baoquan He wrote: > -4G and -68G just a trick which makes people understand easily, still we > think kernel text mapping region is in higher addr area then vmalloc. I > personnally think. Just remove the direction: bottom-up or top-down, it will confuse

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 04:45:13PM +0800, Baoquan He wrote: > -4G and -68G just a trick which makes people understand easily, still we > think kernel text mapping region is in higher addr area then vmalloc. I > personnally think. Just remove the direction: bottom-up or top-down, it will confuse

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 10:35am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: > > Yes, it looks better. I can repost with this change. Thanks. > > No it doesn't: All right, I will just update the code comment. Just back ported kaslr to our OS product, people

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 10:35am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: > > Yes, it looks better. I can repost with this change. Thanks. > > No it doesn't: All right, I will just update the code comment. Just back ported kaslr to our OS product, people

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 02:30pm, Bhupesh Sharma wrote: > Hi Dave, > > On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > >> - * We allocate runtime services regions bottom-up, starting from -4G, i.e. > >> + * We allocate runtime services

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 02:30pm, Bhupesh Sharma wrote: > Hi Dave, > > On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > >> - * We allocate runtime services regions bottom-up, starting from -4G, i.e. > >> + * We allocate runtime services regions top-down,

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: > Yes, it looks better. I can repost with this change. Thanks. No it doesn't: #define EFI_VA_START ( -4 * (_AC(1, UL) << 30)) #define EFI_VA_END (-68 * (_AC(1, UL) << 30)) That's -4G (the shift by 30) and -68G, respectively.

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: > Yes, it looks better. I can repost with this change. Thanks. No it doesn't: #define EFI_VA_START ( -4 * (_AC(1, UL) << 30)) #define EFI_VA_END (-68 * (_AC(1, UL) << 30)) That's -4G (the shift by 30) and -68G, respectively.

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 02:30pm, Bhupesh Sharma wrote: > Hi Dave, > > On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > >> EFI allocate runtime services regions down from EFI_VA_START, -4G. > >> It should be top-down handling. > >> > >>

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 02:30pm, Bhupesh Sharma wrote: > Hi Dave, > > On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > > On 03/08/17 at 03:47pm, Baoquan He wrote: > >> EFI allocate runtime services regions down from EFI_VA_START, -4G. > >> It should be top-down handling. > >> > >> Signed-off-by:

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 09:54am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 04:45:13PM +0800, Baoquan He wrote: > > -4G and -68G just a trick which makes people understand easily, still we > > think kernel text mapping region is in higher addr area then vmalloc. I > > personnally think. > > Just

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 09:54am, Borislav Petkov wrote: > On Wed, Mar 08, 2017 at 04:45:13PM +0800, Baoquan He wrote: > > -4G and -68G just a trick which makes people understand easily, still we > > think kernel text mapping region is in higher addr area then vmalloc. I > > personnally think. > > Just

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Forgot cc to Boris, add him. On 03/08/17 at 04:18pm, Dave Young wrote: > On 03/08/17 at 03:47pm, Baoquan He wrote: > > EFI allocate runtime services regions down from EFI_VA_START, -4G. > > It should be top-down handling. > > > > Signed-off-by: Baoquan He > > --- > >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Forgot cc to Boris, add him. On 03/08/17 at 04:18pm, Dave Young wrote: > On 03/08/17 at 03:47pm, Baoquan He wrote: > > EFI allocate runtime services regions down from EFI_VA_START, -4G. > > It should be top-down handling. > > > > Signed-off-by: Baoquan He > > --- > >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Hi Dave, On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > On 03/08/17 at 03:47pm, Baoquan He wrote: >> EFI allocate runtime services regions down from EFI_VA_START, -4G. >> It should be top-down handling. >> >> Signed-off-by: Baoquan He >> --- >>

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

Hi Dave, On Wed, Mar 8, 2017 at 1:48 PM, Dave Young wrote: > On 03/08/17 at 03:47pm, Baoquan He wrote: >> EFI allocate runtime services regions down from EFI_VA_START, -4G. >> It should be top-down handling. >> >> Signed-off-by: Baoquan He >> --- >> arch/x86/platform/efi/efi_64.c | 2 +- >> 1

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 03:47pm, Baoquan He wrote: > EFI allocate runtime services regions down from EFI_VA_START, -4G. > It should be top-down handling. > > Signed-off-by: Baoquan He > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

On 03/08/17 at 03:47pm, Baoquan He wrote: > EFI allocate runtime services regions down from EFI_VA_START, -4G. > It should be top-down handling. > > Signed-off-by: Baoquan He > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git