Re: [PATCH 1/2 v3] eventfs: Remove eventfs_file and just use eventfs_inode

2023-09-20 Thread Steven Rostedt
On Tue, 19 Sep 2023 21:18:04 -0400 Steven Rostedt wrote: > Hmm, actually looking at this, it's worse than what you stated. This is > called when a directory is closed. So if you had: > > open(dir); > > // look at all the content of this dir to create dentries > > // another t

Re: [PATCH 1/2 v3] eventfs: Remove eventfs_file and just use eventfs_inode

2023-09-19 Thread Steven Rostedt
On Tue, 19 Sep 2023 18:41:09 +0900 Masami Hiramatsu (Google) wrote: > > > > ti = get_tracefs(inode); > > > > if (!(ti->flags & TRACEFS_EVENT_INODE)) > > > > @@ -375,10 +485,18 @@ static int eventfs_release(struct inode *inode, > > > > struct file *file) > > > > > > > >

Re: [PATCH 1/2 v3] eventfs: Remove eventfs_file and just use eventfs_inode

2023-09-19 Thread Google
On Mon, 18 Sep 2023 21:04:56 -0400 Steven Rostedt wrote: > > > @@ -144,18 +129,18 @@ static struct dentry *create_dir(const char *name, > > > struct dentry *parent, void * > > > } > > > > > > /** > > > - * eventfs_set_ef_status_free - set the ef->status to free > > > + * eventfs_set_ei_stat

Re: [PATCH 1/2 v3] eventfs: Remove eventfs_file and just use eventfs_inode

2023-09-18 Thread Steven Rostedt
On Tue, 19 Sep 2023 00:01:29 +0900 Masami Hiramatsu (Google) wrote: > > Thanks for this great work! Thanks! > I have some questions below. > I tried to understand this, but maybe some of them are pointless. Sure. > > > Signed-off-by: Steven Rostedt (Google) > > --- > > fs/tracefs/event_in

Re: [PATCH 1/2 v3] eventfs: Remove eventfs_file and just use eventfs_inode

2023-09-18 Thread Google
Hi Steve, On Thu, 14 Sep 2023 12:35:05 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Instead of having a descriptor for every file represented in the eventfs > directory, only have the directory itself represented. Change the API to > send in a list of entries that represen